Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore:docs Adding back references to yarn build #31480

Merged
merged 6 commits into from
Jun 3, 2024

Conversation

mltejera
Copy link
Contributor

There is a large contingent of contributors at MSFT using vanilla windows, rather than a unix based system.

Sometimes running a yarn build is the right thing for them to do.

Many developers are accustomed to yarn building regularly.

This adds it back to the docs.

@mltejera mltejera requested review from a team as code owners May 24, 2024 21:49
Copy link

codesandbox-ci bot commented May 24, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@fabricteam
Copy link
Collaborator

fabricteam commented May 24, 2024

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 619 637 5000
Button mount 312 305 5000
Field mount 1128 1121 5000
FluentProvider mount 706 724 5000
FluentProviderWithTheme mount 79 80 10
FluentProviderWithTheme virtual-rerender 38 39 10
FluentProviderWithTheme virtual-rerender-with-unmount 71 72 10
MakeStyles mount 858 877 50000
Persona mount 1757 1712 5000
SpinButton mount 1406 1390 5000
SwatchPicker mount 1525 1562 5000

@fabricteam
Copy link
Collaborator

fabricteam commented May 24, 2024

Perf Analysis (@fluentui/react-northstar)

⚠️ 1 potential perf regressions detected

Potential regressions comparing to master

Scenario Current PR Ticks Baseline Ticks Ratio Regression Analysis
AttachmentMinimalPerf.default 79 82 0.96:1 analysis
Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
TextAreaMinimalPerf.default 305 272 1.12:1
FormMinimalPerf.default 237 216 1.1:1
PortalMinimalPerf.default 88 81 1.09:1
SkeletonMinimalPerf.default 201 185 1.09:1
ButtonMinimalPerf.default 91 84 1.08:1
CardMinimalPerf.default 321 296 1.08:1
BoxMinimalPerf.default 207 193 1.07:1
CarouselMinimalPerf.default 269 251 1.07:1
RadioGroupMinimalPerf.default 270 252 1.07:1
ImageMinimalPerf.default 236 224 1.05:1
ToolbarMinimalPerf.default 561 534 1.05:1
HeaderMinimalPerf.default 215 206 1.04:1
ItemLayoutMinimalPerf.default 729 698 1.04:1
ProviderMinimalPerf.default 205 198 1.04:1
ReactionMinimalPerf.default 218 209 1.04:1
RefMinimalPerf.default 109 105 1.04:1
ButtonSlotsPerf.default 314 306 1.03:1
DatepickerMinimalPerf.default 3742 3625 1.03:1
DialogMinimalPerf.default 452 440 1.03:1
FlexMinimalPerf.default 157 153 1.03:1
InputMinimalPerf.default 542 526 1.03:1
TableMinimalPerf.default 243 237 1.03:1
TreeWith60ListItems.default 94 91 1.03:1
ButtonOverridesMissPerf.default 651 640 1.02:1
ChatDuplicateMessagesPerf.default 146 143 1.02:1
ChatWithPopoverPerf.default 193 190 1.02:1
DividerMinimalPerf.default 201 198 1.02:1
DropdownMinimalPerf.default 1418 1390 1.02:1
EmbedMinimalPerf.default 1877 1834 1.02:1
ListMinimalPerf.default 309 303 1.02:1
MenuMinimalPerf.default 505 493 1.02:1
AlertMinimalPerf.default 153 152 1.01:1
CheckboxMinimalPerf.default 1126 1120 1.01:1
GridMinimalPerf.default 188 187 1.01:1
MenuButtonMinimalPerf.default 953 942 1.01:1
SegmentMinimalPerf.default 191 190 1.01:1
SplitButtonMinimalPerf.default 2268 2255 1.01:1
TableManyItemsPerf.default 1115 1103 1.01:1
AccordionMinimalPerf.default 85 85 1:1
ListNestedPerf.default 327 326 1:1
StatusMinimalPerf.default 380 379 1:1
CustomToolbarPrototype.default 1450 1451 1:1
TreeMinimalPerf.default 481 481 1:1
AnimationMinimalPerf.default 298 300 0.99:1
LabelMinimalPerf.default 222 224 0.99:1
LoaderMinimalPerf.default 194 195 0.99:1
PopupMinimalPerf.default 347 351 0.99:1
TextMinimalPerf.default 187 189 0.99:1
TooltipMinimalPerf.default 1244 1260 0.99:1
AttachmentSlotsPerf.default 645 661 0.98:1
AvatarMinimalPerf.default 99 101 0.98:1
ChatMinimalPerf.default 436 443 0.98:1
DropdownManyItemsPerf.default 381 389 0.98:1
HeaderSlotsPerf.default 457 466 0.98:1
RosterPerf.default 1525 1560 0.98:1
VideoMinimalPerf.default 418 427 0.98:1
ProviderMergeThemesPerf.default 641 660 0.97:1
IconMinimalPerf.default 386 397 0.97:1
ListCommonPerf.default 373 389 0.96:1
SliderMinimalPerf.default 710 736 0.96:1
LayoutMinimalPerf.default 194 204 0.95:1
ListWith60ListItems.default 362 380 0.95:1

@fabricteam
Copy link
Collaborator

fabricteam commented May 24, 2024

🕵 FluentUIV0 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

fabricteam commented May 24, 2024

📊 Bundle size report

✅ No changes found

@fabricteam
Copy link
Collaborator

fabricteam commented May 24, 2024

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 633 602 5000
Breadcrumb mount 1646 1687 1000
Checkbox mount 1709 1715 5000
CheckboxBase mount 1467 1516 5000
ChoiceGroup mount 2980 2946 5000
ComboBox mount 657 672 1000
CommandBar mount 6418 6375 1000
ContextualMenu mount 12042 12643 1000
DefaultButton mount 788 800 5000
DetailsRow mount 2222 2163 5000
DetailsRowFast mount 2218 2196 5000
DetailsRowNoStyles mount 2014 2012 5000
Dialog mount 2880 2623 1000
DocumentCardTitle mount 223 220 1000
Dropdown mount 1983 1979 5000
FocusTrapZone mount 1110 1140 5000
FocusZone mount 1082 1081 5000
GroupedList mount 37610 41647 2
GroupedList virtual-rerender 17963 20095 2
GroupedList virtual-rerender-with-unmount 54396 54328 2
GroupedListV2 mount 229 228 2
GroupedListV2 virtual-rerender 212 201 2
GroupedListV2 virtual-rerender-with-unmount 246 227 2
IconButton mount 1127 1150 5000
Label mount 341 345 5000
Layer mount 2718 2748 5000
Link mount 404 394 5000
MenuButton mount 955 959 5000
MessageBar mount 21155 21482 5000
Nav mount 1999 2011 1000
OverflowSet mount 792 778 5000
Panel mount 1762 1806 1000
Persona mount 738 764 1000
Pivot mount 889 927 1000
PrimaryButton mount 919 916 5000
Rating mount 4660 4604 5000
SearchBox mount 902 929 5000
Shimmer mount 1919 1892 5000
Slider mount 1331 1303 5000
SpinButton mount 2966 2950 5000
Spinner mount 388 391 5000
SplitButton mount 1847 1844 5000
Stack mount 413 412 5000
StackWithIntrinsicChildren mount 877 856 5000
StackWithTextChildren mount 2670 2608 5000
SwatchColorPicker mount 6334 6227 5000
TagPicker mount 1451 1460 5000
Text mount 368 375 5000
TextField mount 942 942 5000
ThemeProvider mount 834 840 5000
ThemeProvider virtual-rerender 579 575 5000
ThemeProvider virtual-rerender-with-unmount 1313 1271 5000
Toggle mount 623 607 5000
buttonNative mount 187 189 5000

docs/react-v9/contributing/dev-workflow.md Outdated Show resolved Hide resolved
docs/react-v9/contributing/common-dev-snags.md Outdated Show resolved Hide resolved
docs/react-v9/contributing/dev-workflow.md Outdated Show resolved Hide resolved
@Mitch-At-Work Mitch-At-Work requested a review from Hotell May 28, 2024 18:03
@Mitch-At-Work Mitch-At-Work merged commit 80e5bbd into microsoft:master Jun 3, 2024
22 checks passed
miroslavstastny pushed a commit to miroslavstastny/fluentui that referenced this pull request Jun 14, 2024
Co-authored-by: Mitch-At-Work <mifraser@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants