Suggestions: Fix suggestions arrow scroll bug #4881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joschect
requested review from
cliffkoh,
dzearing,
Markionium,
amyngu and
JasonGore
amyngu
approved these changes
May 16, 2018
| public componentDidUpdate(): void { | ||
| // Only scroll to selected element if the selected element has changed. Otherwise do nothing. | ||
| // This prevents some odd behavior where scrolling the active element out of view and clicking on a selected element | ||
| // will trigger a focus event and not give the clicked element the click. | ||
| if (this.activeSelectedElement && this._selectedElement.current && this.activeSelectedElement !== this._selectedElement.current) { | ||
| if (this._selectedElement.current && this.activeSelectedElement !== this._selectedElement.current) { |
There was a problem hiding this comment.
I think this._selectedElement could be null, should have a null check incase
There was a problem hiding this comment.
I don't believe it can be, because it's created at component initialization with createRef
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ npm run changeDescription of changes
Fix a bug where arrowing would not scroll appropriately.
Focus areas to test
(optional)