-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Perf Test: Fix on 6.0 #9566
Perf Test: Fix on 6.0 #9566
Conversation
Hello @JasonGore! Because this pull request has the Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 8 hours. No worries though, I will be back when the time is right! 😉 p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could probably also fix by using process.env.BUILD_HEADBRANCH or whatever the env name is, which is more resilient against this branch ever getting renamed
Component perf results:
|
Size Auditor did not detect a change in bundle size for any component! |
Thanks Cliff. I want to make more improvements on |
The described improvement is more important in master branch. It is far less likely 6.0 will change. |
Pull request checklist
$ npm run change
Description of changes
#9550 changed the baseline tests for master. This ended up breaking 6.0 builds because the 6.0 branch hadn't been switched over to use 6.0 deploy links for its baseline tests. This PR fixes this problem.
Microsoft Reviewers: Open in CodeFlow