Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perf Test: Fix on 6.0 #9566

Merged
merged 1 commit into from
Jun 25, 2019
Merged

Perf Test: Fix on 6.0 #9566

merged 1 commit into from
Jun 25, 2019

Conversation

JasonGore
Copy link
Member

@JasonGore JasonGore commented Jun 25, 2019

Pull request checklist

  • Addresses an existing issue: Fixes #0000
  • Include a change request file using $ npm run change

Description of changes

#9550 changed the baseline tests for master. This ended up breaking 6.0 builds because the 6.0 branch hadn't been switched over to use 6.0 deploy links for its baseline tests. This PR fixes this problem.

Microsoft Reviewers: Open in CodeFlow

@msft-github-bot
Copy link
Contributor

Hello @JasonGore!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 8 hours. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msft-github-bot) and give me an instruction to get started! Learn more here.

Copy link
Contributor

@cliffkoh cliffkoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could probably also fix by using process.env.BUILD_HEADBRANCH or whatever the env name is, which is more resilient against this branch ever getting renamed

@msft-github-bot
Copy link
Contributor

Component perf results:

Scenario Target branch avg total (ms) PR avg total (ms) Target branch avg per item (ms) PR avg per item (ms) Is significant change Is regression
PrimaryButton 53.219 53.122 0.532 0.531 false false
BaseButton 30.486 29.419 0.305 0.294 false false
NewButton 56.492 57.476 0.565 0.575 false false
button 5.229 4.957 0.052 0.050 false false
DetailsRows without styles 166.043 164.012 1.660 1.640 false false
DetailsRows 167.010 165.507 1.670 1.655 false false
Toggles 34.402 32.436 0.344 0.324 true false
NewToggle 64.188 63.567 0.642 0.636 false false
DocumentCardTitle with truncation 19.633 20.020 0.196 0.200 false false

@size-auditor
Copy link

size-auditor bot commented Jun 25, 2019

Size Auditor did not detect a change in bundle size for any component!

@JasonGore
Copy link
Member Author

Thanks Cliff. I want to make more improvements on master so I'll try that change there first and then port it over. I'll merge this for now.

@JasonGore JasonGore merged commit e834389 into microsoft:6.0 Jun 25, 2019
@cliffkoh
Copy link
Contributor

The described improvement is more important in master branch. It is far less likely 6.0 will change.

@microsoft microsoft locked as resolved and limited conversation to collaborators Aug 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants