Perf Test: Flamegraphs #9550
Merged
Perf Test: Flamegraphs #9550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ersion. Fix React render consumption caused by use of fragments.
…from perf-test app.
apps/perf-test/tasks/perf-test.js
Outdated
|
|
||
| // A high number of iterations are needed to get visualization of lower level calls that are infrequently hit by ticks. | ||
| // TODO: change to 5000 | ||
| const iterations = 10; |
There was a problem hiding this comment.
Worth defaulting to 5000 but allow for CLI arg?
There was a problem hiding this comment.
Possibly. I think it'd also be useful to control which scenarios are running as most people who run locally will most likely only care about one or two.
|
I had to make this PR to test PR integration and work with Ken to fix up a deploy issue. Will be doing more cleanup along the way. |
|
Size Auditor did not detect a change in bundle size for any component! |
|
Component Perf Analysis:
|
|
Yay, flamegraph links are working. Master in this case is still old perf-test, so results won't be comparable until after this PR is merged. |
kenotron
requested changes
Jun 24, 2019
kenotron
approved these changes
Jun 24, 2019
cliffkoh
approved these changes
Jun 24, 2019
KevinTCoughlin
approved these changes
Jun 24, 2019
This was referenced Jun 25, 2019
Merged
gingeroun
pushed a commit
to gingeroun/office-ui-fabric-react
that referenced
this pull request
Jul 5, 2019
* Port changes from 6.0 to master. * WIP: working on scenario list * scenario list go! * fix shrinkwrap * scenariolist fix * hooking it up with perf-test * Clean up flamegraphs regressed from webpack server to local file conversion. Fix React render consumption caused by use of fragments. * Add master reference tests. Generate results blob. Add all scenarios from perf-test app. * Fix master URL. * Fix shrinkwrap. * Add path for perf-tests task since it was removed from root config. * Fix perf-test command. * Copy perf test results to PR deploy site. Add BaseButtonNew case. * Tweak output. * Final cleanup. * Disable puppeteer timeout.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ npm run changeDescription of changes
This PR replaces the existing perf test table with a new process that generates profiles using Puppeteer / V8 and uses those profiles to generate flamegraphs. All sample counts and flamegraphs will be added as comments to the PR, just as existing perf test package operates.
There are many improvements to come, but for now this first iteration provides the following:
Hopefully examples will show up when this PR builds.
Microsoft Reviewers: Open in CodeFlow