-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Perf Test: Add missing copy step #9571
Conversation
Size Auditor did not detect a change in bundle size for any component! |
Component Perf Analysis:
|
Hello @cliffkoh! Because this pull request has the Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 8 hours, a condition that will be fulfilled in about 6 hours 17 minutes. No worries though, I will be back when the time is right! 😉 p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
@msft-github-bot merge in 1 hour |
Hello @cliffkoh! Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:
If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you". |
* Re-add copy step before perf-test runs. * Fix URL for master.
Pull request checklist
$ npm run change
Description of changes
The results of #9516 exposed an issue where a missing copy step caused the PR to run against an old version of
perf-test
. We initially removed this copy step in #9550 because we thought it would cause an error on the second copy including test results, but didn't consider this would result in PRs using an old copy ofindex.html
.Microsoft Reviewers: Open in CodeFlow