Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perf Test: Add missing copy step #9571

Merged
merged 2 commits into from
Jun 25, 2019
Merged

Perf Test: Add missing copy step #9571

merged 2 commits into from
Jun 25, 2019

Conversation

JasonGore
Copy link
Member

@JasonGore JasonGore commented Jun 25, 2019

Pull request checklist

  • Addresses an existing issue: Fixes #0000
  • Include a change request file using $ npm run change

Description of changes

The results of #9516 exposed an issue where a missing copy step caused the PR to run against an old version of perf-test. We initially removed this copy step in #9550 because we thought it would cause an error on the second copy including test results, but didn't consider this would result in PRs using an old copy of index.html.

Microsoft Reviewers: Open in CodeFlow

@size-auditor
Copy link

size-auditor bot commented Jun 25, 2019

Size Auditor did not detect a change in bundle size for any component!

@msft-github-bot
Copy link
Contributor

msft-github-bot commented Jun 25, 2019

Component Perf Analysis:

Scenario Master Samples * PR Samples *
BaseButton 880 890
BaseButtonNew 3695 3663
DefaultButton 1169 1196
DefaultButtonNew 3239 3256
DetailsRow 8563 8524
DetailsRowNoStyles 6353 6424
DocumentCardTitle 43288 42327
MenuButton 1920 1963
MenuButtonNew 6092 6123
PrimaryButton 1320 1346
PrimaryButtonNew 3513 3705
SplitButton 3920 3805
SplitButtonNew 13791 13290
Toggle 2007 1969
ToggleNew 2457 2437
button 76 85
* Sample counts can vary by up to 30% and shouldn't be used solely for determining regression. Flamegraph links are provided to give a hint on deltas introduced by PRs and potential bottlenecks.

@msft-github-bot
Copy link
Contributor

Hello @cliffkoh!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 8 hours, a condition that will be fulfilled in about 6 hours 17 minutes. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msft-github-bot) and give me an instruction to get started! Learn more here.

@cliffkoh
Copy link
Contributor

@msft-github-bot merge in 1 hour

@msft-github-bot
Copy link
Contributor

Hello @cliffkoh!

Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:

  • I won't merge this pull request until after the UTC date Tue, 25 Jun 2019 19:16:28 GMT, which is in 1 hour

If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you".

@JasonGore JasonGore merged commit 662f129 into microsoft:master Jun 25, 2019
gingeroun pushed a commit to gingeroun/office-ui-fabric-react that referenced this pull request Jul 5, 2019
* Re-add copy step before perf-test runs.

* Fix URL for master.
@microsoft microsoft locked as resolved and limited conversation to collaborators Aug 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants