Fix TES compliance tests #458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuliadub
commented
Oct 11, 2023
| # openapi-test-runner repo provides a default entry point script, but since TES uses basic auth it needs to be replaced to add approprite credentials | ||
| # https://github.com/elixir-cloud-aai/openapi-test-runner | ||
| openapi-test-runner report --server http://$tesuser:$tespassword@$teshostname/ --tag all --version 1.0.0 --output_path results |
There was a problem hiding this comment.
i asume we are still on version tes 1.0.0, is that correct?
There was a problem hiding this comment.
Great point, yes, and I wonder if we could loop through each TES version (1.0.0, 1.1.0), run the openapi-test-runner, and update the status of a badge on the readme that says "✔️ GA4GH TES 1.0.0", "🏗️ GA4GH TES 1.1.0"
There was a problem hiding this comment.
we certainly can - but this is a bit more of a lift. Great opportunity for someone to pick this up and learn how these tests work (so I am not the only one with this knowledge). I'll make an issue to track this and happy to help if any road blocks are hit.
|
after these changes tests ran successfully:
|
MattMcL4475
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ever since the tes compliance test repo was renamed, the tes tests have not been working due to this change. This PR will fix that.
issues related to this:
#457
#397
#393