Cleanup of the release pipeline: removed a task that didn't work and a switch in Nuget Pack that wasn't used #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in release pipeline. Removed copy task and the $(BuildConfiguration) to the nuget pack task
…. All should work now when ran.
badrishc
reviewed
Apr 26, 2024
badrishc
approved these changes
Apr 26, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is what we found when testing csproj PR. The "Copy Files for Nuget package ..." task and the "$(BuildConfiguration)" setting in the pack task are not needed and were removed. In both cases it is because they used the variable $(BuildConfiguration) and it isn't used anywhere else.