Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Korean Translation #271

Merged
merged 33 commits into from
Mar 26, 2024
Merged

add Korean Translation #271

merged 33 commits into from
Mar 26, 2024

Conversation

FacerAin
Copy link
Contributor

@FacerAin FacerAin commented Jan 7, 2024

This is a PR for korean translation.
I have recorded the work history in the issue.
Thank you 😄

close: #213
@mreraser @Eeap @FacerAin

Copy link

github-actions bot commented Jan 7, 2024

👋 Thanks for contributing @FacerAin! We will review the pull request and get back to you soon.

Copy link

github-actions bot commented Jan 7, 2024

Check Broken Paths

We have automatically detected the following broken relative paths in your lessons. Review and fix the paths to resolve this issue.

Check the file paths and associated broken paths inside them. For more details, check our Contributing Guide.

File Full Path Issues
./02-exploring-and-comparing-different-llms/translations/ko/README.md ['./images/02-lesson-banner.png', './images/FoundationModel.png', './images/Multimodal.png', './images/Embedding.png', './images/Image.png', './images/Text.png', './images/Llama1.png', './images/Llama2.png', './images/Llama3.png', './images/Llama4.png', './images/Deploy.png', '../03-using-generative-ai-responsibly/README.md']
./05-advanced-prompts/translations/ko/README.md ['../../../06-text-generation-apps/translations/ko/README.md']
./translations/ko/README.md ['../../06-text-generation-apps/translations/ko/README.md', '../../07-building-chat-applications/translations/ko/README.md']

Copy link

github-actions bot commented Jan 7, 2024

Check Missing Tracking from Paths

We have automatically detected missing tracking id from the following relative paths in your lessons. Review and add tracking to paths to resolve this issue.

Check the file paths and associated paths inside them. For more details, check our Contributing Guide.

File Full Path Issues
./11-integrating-with-function-calling/translations/ko/README.md ['../../Lesson11-FunctionCalling.ipynb']

Copy link

github-actions bot commented Jan 8, 2024

Check Broken Paths

We have automatically detected the following broken relative paths in your lessons. Review and fix the paths to resolve this issue.

Check the file paths and associated broken paths inside them. For more details, check our Contributing Guide.

File Full Path Issues
./07-building-chat-applications/translations/ko/README.md ['./notebook-openai.ipynb', './notebook-azure-openai.ipynb']

Copy link

github-actions bot commented Jan 8, 2024

Check Missing Tracking from Paths

We have automatically detected missing tracking id from the following relative paths in your lessons. Review and add tracking to paths to resolve this issue.

Check the file paths and associated paths inside them. For more details, check our Contributing Guide.

File Full Path Issues
./11-integrating-with-function-calling/translations/ko/README.md ['../../Lesson11-FunctionCalling.ipynb']

Copy link

github-actions bot commented Jan 9, 2024

Check Broken Paths

We have automatically detected the following broken relative paths in your lessons. Review and fix the paths to resolve this issue.

Check the file paths and associated broken paths inside them. For more details, check our Contributing Guide.

File Full Path Issues
./06-text-generation-apps/translations/ko/README.md ['../../07-building-chat-applications/README.md']

@FacerAin
Copy link
Contributor Author

@koreyspace
related issue: #213

Thank you for taking the time to review our work.
Could you let us know if there's anything we need to improve or consider for the next phase?
Thanks 😄

@koreyspace
Copy link
Collaborator

Hey @FacerAin apologies for missing this and not merging sooner. I was keeping track of the todos but did not see you and the team had completed them! Thanks for your contribution.

@koreyspace koreyspace merged commit 48b8c6c into microsoft:main Mar 26, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Korean Translation
3 participants