Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: fix the vs-build job so that CI builds pass again #300

Merged
merged 1 commit into from
Dec 4, 2020
Merged

ci: fix the vs-build job so that CI builds pass again #300

merged 1 commit into from
Dec 4, 2020

Commits on Dec 4, 2020

  1. ci(vs-build): stop passing the iconv library location explicitly 

    Something changed in `vcpkg` (which we use in our Visual C++ build to
provide the dependencies such as libcurl) and our `vs-build` job started
failing in CI. The reason is that we had a work-around in place to help
CMake find iconv, and this work-around is neither needed nor does it
work anymore.

For the full discussion with the vcpkg project, see this comment:
microsoft/vcpkg#14780 (comment)

Signed-off-by: Dennis Ameling <dennis@dennisameling.com>
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
    @dennisameling @dscho
    dennisameling authored and dscho committed Dec 4, 2020
    Configuration menu
    Copy the full SHA
    6d4fea1 View commit details
    Browse the repository at this point in the history