Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

winget: fix asset/release regexes to match correctly #475

Merged
merged 1 commit into from
Dec 14, 2021

Conversation

ldennington
Copy link
Collaborator

@ldennington ldennington commented Dec 14, 2021

We had a couple issues in our release-winget pipeline that were obfuscated by the error we were getting from wingetcreate (fixed with #206) and some confusion with PowerShell variables:

  1. We were matching on .exe, meaning we matched on both the Git and PortableGit assets. This caused wingetcreate to attempt to update the Microsoft.Git manifest with both assets and return the initial error that tipped us off to something being amiss: Updating a manifest is only supported with the same number of installer URLs. This has been fixed by instead matching on 64-bit.exe.

  2. We were trying to match on the $assets variable, which does not exist in this version of the script. This caused the initial value of $Matches[0] to be saved to the $version variable, and the version that the Microsoft.Git manifest was updated to was 64-bit.exe, rather than 2.34.1.0.0. This was corrected by updating $assets to $github.release.

Here is a repro of the initial failure described in item 1 above:
https://github.com/ldennington/git/runs/4512447452?check_suite_focus=true

Here is a repro of the version error described in item 2 above:
https://github.com/ldennington/git/runs/4513024477?check_suite_focus=true

Here is a successful run with the fixes in place:
https://github.com/ldennington/git/runs/4513446852?check_suite_focus=true

@dscho
Copy link
Member

dscho commented Dec 14, 2021

And the Scalar tests finally passed ;-)

@ldennington ldennington merged commit 7a514b4 into microsoft:vfs-2.34.0 Dec 14, 2021
ldennington added a commit to ldennington/git that referenced this pull request Jan 12, 2022
winget: fix asset/release regexes to match correctly
ldennington added a commit to ldennington/git that referenced this pull request Jan 19, 2022
winget: fix asset/release regexes to match correctly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants