jeffhostetler/native-curl #636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run `otool -L` on each of the major executables and print the name of the CPU architecture(s) and the name and version of the referenced dynamic libraries. In a later commit, we might want to verify that certain minimim versions were linked or that there are no unexpected third-party libraries in the linkage (such as an unexpected homebrew). Signed-off-by: Jeff Hostetler <jeffhostetler@github.com>
Stop building custom universal libcurl dylib and let Git binaries use the version installed on the OS, like we do for other libraries. Signed-off-by: Jeff Hostetler <jeffhostetler@github.com>
jeffhostetler
changed the title
vdye
approved these changes
Mar 26, 2024
This was referenced Mar 26, 2024
dscho
pushed a commit
that referenced
this pull request
Apr 23, 2024
Use the OS provided version of `libcurl` when building release packages. This is in contrast to using Homebrew on ARM64 in our universal binaries. Also add diagnostics during the release build process to display the DYLIBs that are referenced by the key executables.
dscho
pushed a commit
that referenced
this pull request
Apr 23, 2024
Use the OS provided version of `libcurl` when building release packages. This is in contrast to using Homebrew on ARM64 in our universal binaries. Also add diagnostics during the release build process to display the DYLIBs that are referenced by the key executables.
dscho
pushed a commit
that referenced
this pull request
Apr 23, 2024
Use the OS provided version of `libcurl` when building release packages. This is in contrast to using Homebrew on ARM64 in our universal binaries. Also add diagnostics during the release build process to display the DYLIBs that are referenced by the key executables.
dscho
pushed a commit
that referenced
this pull request
Apr 23, 2024
Use the OS provided version of `libcurl` when building release packages. This is in contrast to using Homebrew on ARM64 in our universal binaries. Also add diagnostics during the release build process to display the DYLIBs that are referenced by the key executables.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the OS provided version of
libcurlwhen building release packages.This is in contrast to using Homebrew on ARM64 in our universal binaries.
Also add diagnostics during the release build process to display the DYLIBs
that are referenced by the key executables.