nodegyp => cmakejs #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richard1122
force-pushed
the
linyhe/cmakejs
branch
from
d1adbd7
to
5956093
Compare
richard1122
force-pushed
the
linyhe/cmakejs
branch
2 times, most recently
from
d887216
to
5a8bd80
Compare
richard1122
force-pushed
the
linyhe/cmakejs
branch
from
5a8bd80
to
aa7e76a
Compare
richard1122
force-pushed
the
linyhe/cmakejs
branch
from
13ad6dd
to
1322c5c
Compare
richard1122
force-pushed
the
linyhe/cmakejs
branch
from
1322c5c
to
8053cd4
Compare
richard1122
force-pushed
the
linyhe/cmakejs
branch
from
93b0ece
to
1ae373d
Compare
richard1122
force-pushed
the
linyhe/cmakejs
branch
from
1ae373d
to
94e12fb
Compare
Qusic
reviewed
Oct 25, 2021
script/index.ts
Outdated
Comment on lines
143
to
144
| remove('Debug') | ||
| remove('Release') |
There was a problem hiding this comment.
nodegyp's compdb generator puts files in these two folders. are the two lines still needed?
There was a problem hiding this comment.
Removed..I'm not aware what are those two folders generated from.
addon/addon.cc
Outdated
Comment on lines
8
to
11
| #if defined(_MSC_VER) | ||
| #pragma warning(push) | ||
| #pragma warning(disable : 4244) | ||
| #endif |
There was a problem hiding this comment.
can we simply disable it in cmake? also it's disabled in gn's own gen script here
script/index.ts
Outdated
Comment on lines
138
to
141
| if (!fs.existsSync(`build/${file}`)) { | ||
| console.warn('compile_commands.json is not supported.') | ||
| return | ||
| } |
There was a problem hiding this comment.
remove this and add if (os.platform() != 'win32') for the call site at line 168. so we can keep these functions clean and make it very clear what works and what doesnt work on each platform.
some nits
Qusic
approved these changes
Oct 25, 2021
richard1122
added a commit
that referenced
this pull request
Oct 25, 2021
This reverts commit 514f86a.
richard1122
added a commit
that referenced
this pull request
Oct 25, 2021
richard1122
added a commit
to richard1122/gnls
that referenced
this pull request
Dec 26, 2022
* WIP: cmake-js * Fix build * Format * Fix debug build * Fix debug build * Fix build on windows, fix warnings * Support clangd * Remove gyp * Fix clangd support * Comments * Update index.ts some nits Co-authored-by: Bang Lee <qusicx@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.