Supported version update #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This seems to have gotten out of date.
dagood
approved these changes
Feb 22, 2023
| @@ -26,7 +26,7 @@ On the other hand, Google maintains a branch that uses cgo and BoringSSL to impl | |||
|
|
|||
| ### Multiple OpenSSL versions supported | |||
|
|
|||
| The `openssl` package has support for multiple OpenSSL versions, namely 1.0.1, 1.1.0, 1.1.1 and 3.0.2. | |||
| The `openssl` package has support for multiple OpenSSL versions, namely 1.0.2, 1.1.0, 1.1.1 and 3.0.2. | |||
There was a problem hiding this comment.
Hmm... should 3.0.2 be changed to 3.0.1 also, to match what CI tests? @qmuntal
go-crypto-openssl/.github/workflows/test.yml
Lines 9 to 10 in 2cec441
(This might also explain the typo--patch versions swapped between these two.)
There was a problem hiding this comment.
We should support all OpenSSL 3.0 versions at once, in theory the new versioning policy forbides API breakages between patch versions. Having said this, it might be good to test with OpenSSL 3.0.0 and OpenSSL 3.0.8 (the latest at this moment).
qmuntal
approved these changes
Feb 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to have gotten out of date.