simplify devcontainer #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dagood
approved these changes
May 24, 2023
.devcontainer/devcontainer.json
Outdated
| "customizations": { | ||
| "vscode": { | ||
| "extensions": ["golang.go"] | ||
| "extensions": [ | ||
| "golang.go" |
There was a problem hiding this comment.
I would expect that this is included by default based on https://github.com/devcontainers/features/tree/main/src/go#customizations and the fact that it's a pretty standard extension, but I wasn't able to find a clear answer whether these are available customizations to pick from or default customizations. 😄 Do you know for sure if this bit is required?
There was a problem hiding this comment.
Hmm, for what I could test, looks like it's not necessary. The only properties settable by users are the ones under options. In fact there is a proposal to allow opting out to the default extensions: devcontainers/features#386.
chsienki
approved these changes
Jun 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no need for an external Dockerfile when using: