Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

simplify devcontainer #52

Merged
merged 3 commits into from
Jun 2, 2023
Merged

simplify devcontainer #52

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b91c3f0
simplify devcontainer
qmuntal May 24, 2023
e802253
remove devcontainer extensions object
qmuntal May 25, 2023
1973167
fix openssl3 install script
qmuntal May 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions .devcontainer/Dockerfile
View file
Open in desktop

This file was deleted.

19 changes: 9 additions & 10 deletions .devcontainer/devcontainer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,19 +2,18 @@

{
"name": "Go",
"build": {
"dockerfile": "Dockerfile",
"args": {
"VARIANT": "1.17-bullseye",
}
},
"containerEnv": {
"GO_OPENSSL_VERSION_OVERRIDE": "1.1.0",
"GO_OPENSSL_VERSION_OVERRIDE": "1.1.1"
},
"onCreateCommand": "sh ${containerWorkspaceFolder}/scripts/openssl.sh ${GO_OPENSSL_VERSION_OVERRIDE}",
"features": {
"ghcr.io/devcontainers/features/go:1": {}
},
"onCreateCommand": "sudo sh ${containerWorkspaceFolder}/scripts/openssl.sh ${GO_OPENSSL_VERSION_OVERRIDE}",
"customizations": {
"vscode": {
"extensions": ["golang.go"]
"extensions": [
"golang.go"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would expect that this is included by default based on https://github.com/devcontainers/features/tree/main/src/go#customizations and the fact that it's a pretty standard extension, but I wasn't able to find a clear answer whether these are available customizations to pick from or default customizations. 😄 Do you know for sure if this bit is required?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, for what I could test, looks like it's not necessary. The only properties settable by users are the ones under options. In fact there is a proposal to allow opting out to the default extensions: devcontainers/features#386.

]
}
},
}
}