GUID tests to use t.Run #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevpar
reviewed
Aug 23, 2022
|
rebased onto main to fix merge conflicts |
helsaawy
force-pushed
the
he/guid
branch
3 times, most recently
from
76d373b
to
e84434c
Compare
anmaxvl
approved these changes
Aug 24, 2022
kevpar
reviewed
Aug 24, 2022
Switched to subtests using `t.Run()` for GUID testing, rather than using log statements to demarcate different tests. Added `.String` to GUID `Variant` and `Version` using `golang.org/x/tools/cmd/stringer`. Added `tools.go` to version `stringer` in go.mod and allow `go generate ./...` to be run without needing a `go get` call. Based off of [go wiki](https://github.com/golang/go/wiki/Modules#how-can-i-track-tool-dependencies-for-a-module) recommendation. Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Using subtests with
t.Run()for GUID testing.Added
.Stringto GUIDVariantandVersionusinggolang.org/x/tools/cmd/stringer.Added
tools.goto versionstringerin go.mod and allowgo generate ./...to be run without needing ago getcall.Based off of go wiki recommendation.
Signed-off-by: Hamza El-Saawy hamzaelsaawy@microsoft.com