Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GUID tests to use t.Run #256

merged 1 commit into from Aug 29, 2022

GUID tests to use t.Run #256

merged 1 commit into from Aug 29, 2022


Copy link

@helsaawy helsaawy commented Aug 22, 2022

Using subtests with t.Run() for GUID testing.

Added .String to GUID Variant and Version using

Added tools.go to version stringer in go.mod and allow go generate ./... to be run without needing a go get call.
Based off of go wiki recommendation.

Signed-off-by: Hamza El-Saawy

@helsaawy helsaawy requested a review from a team as a code owner August 22, 2022 15:42
tools.go Show resolved Hide resolved
Copy link
Contributor Author

rebased onto main to fix merge conflicts

@helsaawy helsaawy force-pushed the he/guid branch 3 times, most recently from 76d373b to e84434c Compare August 24, 2022 15:49
.github/workflows/ci.yml Outdated Show resolved Hide resolved
Switched to subtests using `t.Run()` for GUID testing, rather than using
log statements to demarcate different tests.

Added `.String` to GUID `Variant` and `Version` using

Added `tools.go` to version `stringer` in go.mod and allow
`go generate ./...` to be run without needing a `go get` call.
Based off of [go wiki](

Signed-off-by: Hamza El-Saawy <>
Copy link

@kevpar kevpar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


@helsaawy helsaawy merged commit 376b201 into microsoft:main Aug 29, 2022
8 checks passed
@helsaawy helsaawy deleted the he/guid branch August 29, 2022 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants