Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make some tests run faster by removing time.Sleeps and modifying implementation #99

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

brenol
Copy link

@brenol brenol commented Oct 13, 2018

Hello!

I made some modifications to pipe_test.go so we use channels to signal we have closed/we are not ready anymore (timing out).

I hope this is a correct implementation as some tests are flaky (i.e. even with incorrect changes they seemed to be passing).

Thanks!

@msftclas
Copy link

msftclas commented Oct 13, 2018

CLA assistant check
All CLA requirements met.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants