Update go-infra: detect VERSION
or go/VERSION
#429
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VERSION
go-infra#22When we changed to submodules, I changed
eng/pipeline/rolling-internal-pipeline.yml
to point atgo/VERSION
rather thanVERSION
. Updating the file detection in microsoft/go rather than microsoft/go-infra was a quick fix.However, the boring branches don't have
VERSION
files. This means in the build asset JSON files, boring builds have the defaultmain-1
value in them, because there's no version info. So, auto-update into microsoft/go-images isn't working.To fix this, I changed go-infra to first check
VERSION
(in our repo) thengo/VERSION
(the submodule). (microsoft/go-infra#22) This means we can undo theeng/pipeline/rolling-internal-pipeline.yml
change. In the boring branches, we can check in our ownVERSION
file to make auto-update work.We probably also need a
VERSION
file to exist in the boring branches for some future work: