Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update go-infra: detect VERSION or go/VERSION #429

Merged
merged 1 commit into from
Feb 14, 2022

Conversation

dagood
Copy link
Member

@dagood dagood commented Feb 11, 2022

When we changed to submodules, I changed eng/pipeline/rolling-internal-pipeline.yml to point at go/VERSION rather than VERSION. Updating the file detection in microsoft/go rather than microsoft/go-infra was a quick fix.

However, the boring branches don't have VERSION files. This means in the build asset JSON files, boring builds have the default main-1 value in them, because there's no version info. So, auto-update into microsoft/go-images isn't working.

To fix this, I changed go-infra to first check VERSION (in our repo) then go/VERSION (the submodule). (microsoft/go-infra#22) This means we can undo the eng/pipeline/rolling-internal-pipeline.yml change. In the boring branches, we can check in our own VERSION file to make auto-update work.

We probably also need a VERSION file to exist in the boring branches for some future work:

@dagood dagood merged commit 25f8233 into microsoft:microsoft/main Feb 14, 2022
@dagood dagood deleted the multilevel-version branch February 14, 2022 17:52
dagood added a commit that referenced this pull request Feb 15, 2022
dagood added a commit that referenced this pull request Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants