docs: update READMEs for next-extraction-plugin & webpack-loader #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Bundle size report🤖 This report was generated against da92d1296bec8f44491952457f87fef418340cf4 |
yume-chan
suggested changes
Aug 16, 2022
| ```js | ||
| // next.config.js | ||
| const { withGriffelCSSExtraction } = require('@griffel/webpack-extraction-plugin'); | ||
| const { withGriffelCSSExtraction } = require('@griffel/next-extraction-plugin'); | ||
|
|
||
| module.exports = withGriffelCssExtraction()({ |
There was a problem hiding this comment.
It is CSS in require statement but Css here.
|
|
||
| // If your project uses TypeScript | ||
| config.module.rules.push({ | ||
| test: /\.(ts|tsx)$/, | ||
| exclude: /node_modules/, | ||
| use: [ | ||
| { | ||
| loader: '@griffel/webpack-loader', |
There was a problem hiding this comment.
Also need babelOptions here.
Note that in a typical Next app, @babel/preset-typescript needs to be installed manually.
Maybe better to use next/babel preset which comes with Next, see https://nextjs.org/docs/advanced-features/customizing-babel-config
ling1726
reviewed
Aug 17, 2022
ling1726
approved these changes
Aug 17, 2022
Co-authored-by: ling1726 <lingfangao@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates README files based on feedback from #190.