Update ncproxy to include new ncproxy network and endpoint types #1239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcantah
reviewed
Jan 4, 2022
dcantah
reviewed
Jan 4, 2022
dcantah
reviewed
Jan 4, 2022
dcantah
reviewed
Jan 4, 2022
dcantah
reviewed
Jan 4, 2022
dcantah
reviewed
Jan 4, 2022
dcantah
reviewed
Jan 5, 2022
katiewasnothere
force-pushed
the
ncproxy_network_endpoint
branch
from
99473b5
to
1a3316b
Compare
|
CI's failing on TestPseudoConsolePowershell but.. I don't even think this PR is rebased on top of master which is weird. Could you rebase and repush? |
@dcantah reran CI and everything's green now. |
helsaawy
reviewed
Jan 6, 2022
Signed-off-by: Kathryn Baldauf <kabaldau@microsoft.com>
* Move ncproxy related package to unified location * Add manifest to ncproxy binary Signed-off-by: Kathryn Baldauf <kabaldau@microsoft.com>
* Clean up GetEndpoints and GetNetworks calls * Use individual testing object for tests with subtests * Misc clean up Signed-off-by: Kathryn Baldauf <kabaldau@microsoft.com>
katiewasnothere
force-pushed
the
ncproxy_network_endpoint
branch
from
cde442f
to
fae5736
Compare
dcantah
approved these changes
Jan 19, 2022
Signed-off-by: Kathryn Baldauf <kabaldau@microsoft.com>
helsaawy
approved these changes
Jan 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does the following:
I know this looks like a huge PR but a good chunk of the adds/deletions is the testing and refactoring 😁
Signed-off-by: Kathryn Baldauf kabaldau@microsoft.com