Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip flaky TestPseudoConsolePowershell #1285

Merged
merged 1 commit into from
Jan 25, 2022

Conversation

dcantah
Copy link
Contributor

@dcantah dcantah commented Jan 22, 2022

This test is fairly flaky on the Github CI but seems to run fine locally (maybe pure
luck). Skip this for now to let contributions continue without a hitch and until we
can replace this with a better suited test shortly.

@dcantah dcantah requested a review from a team as a code owner January 22, 2022 00:26
@dcantah
Copy link
Contributor Author

dcantah commented Jan 22, 2022

@katiewasnothere Can you look at this?

=== RUN   TestGetNetworks_NoError
    hcn_networking_test.go:1209: failed to create test network with hcnCreateNetwork failed in Win32: You were not connected because a duplicate name exists on the network. If joining a domain, go to System in Control Panel to change the computer name and try again. If joining a workgroup, choose another workgroup name. (0x34) {"Success":false,"Error":"You were not connected because a duplicate name exists on the network. If joining a domain, go to System in Control Panel to change the computer name and try again. If joining a workgroup, choose another workgroup name. ","ErrorCode":2147942452}

@katiewasnothere
Copy link
Contributor

@dcantah rerunning the CI. That test is a bit flaky as well but only seems to hit every once in a while.

@dcantah
Copy link
Contributor Author

dcantah commented Jan 22, 2022

@katiewasnothere Is it just the hcn network isn't getting cleaned up from another test? I was going to say maybe another test that creates it is running at the same time but we don't run our tests in parallel afaik

@katiewasnothere
Copy link
Contributor

@dcantah Talking to you offline about this. The test likely needs some additional debugging to determine the root cause.

Could you add a "TODO" comment to fix the test?

This test is fairly flaky on the Github CI but seems to run fine locally (maybe pure
luck). Skip this for now to let contributions continue without a hitch and until we
can replace this with a better suited test shortly.

Signed-off-by: Daniel Canter <dcanter@microsoft.com>
@dcantah
Copy link
Contributor Author

dcantah commented Jan 25, 2022

@dcantah Talking to you offline about this. The test likely needs some additional debugging to determine the root cause.

Could you add a "TODO" comment to fix the test?

@katiewasnothere Sorry never replied even though I added the comment. Done!

@helsaawy
Copy link
Contributor

LGTM

@helsaawy helsaawy self-assigned this Jan 25, 2022
@dcantah dcantah merged commit 134fdfa into microsoft:master Jan 25, 2022
princepereira pushed a commit to princepereira/hcsshim that referenced this pull request Aug 29, 2024
This test is fairly flaky on the Github CI but seems to run fine locally (maybe pure
luck). Skip this for now to let contributions continue without a hitch and until we
can replace this with a better suited test shortly.

Signed-off-by: Daniel Canter <dcanter@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants