Fix nil deref in Windows layer setup #1418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The OS of the UVM was being checked by a pointer method at the start of the function when passing in a UVM object is optional. For process isolated and host process containers nil would be passed where this would be hit. Signed-off-by: Daniel Canter <dcanter@microsoft.com>
ambarve
approved these changes
Jun 3, 2022
kiashok
pushed a commit
to kiashok/hcsshim
that referenced
this pull request
Jul 11, 2022
The OS of the UVM was being checked by a pointer method at the start of the function when passing in a UVM object is optional. For process isolated and host process containers nil would be passed where this would be hit. Signed-off-by: Daniel Canter <dcanter@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The OS of the UVM was being checked by a pointer method at the start of the function when passing in a UVM object is optional. For process isolated and host process containers nil would be passed where this would be hit.