Changes to support ipv6 in ncproxy #1452
Conversation
|
First off, super cool! Second, could you add an assert test if you dont already that the |
katiewasnothere
force-pushed
the
ipv6_ncproxy
branch
2 times, most recently
from
1442d98
to
83e4af3
Compare
😊 Which feature check specifically are you referring to? |
|
I mean the dual stack capability is returned as |
|
This one: Line 109 in 176bb06 |
|
Yea does make me wonder if we end up getting both a v4 and v6 addr if we should short circuit if DualStack isn't supported on the machine by checking hcn.IPv6DualStackSupported() |
|
|
||
| func TestModifyNIC_HCN_Error_InvalidArgument(t *testing.T) { | ||
| // support for setting IOV policy was added in 21H1 | ||
| if osversion.Build() < osversion.V21H1 { |
There was a problem hiding this comment.
This applies to some other tests in this file, but we don't have a syso file with the manifest info in it in this directory so I think we'd pretty much permanently skip this test as we'd spit out windows 8's build number
There was a problem hiding this comment.
if you rebase for the functional test PR, you can _ "github.com/Microsoft/hcsshim/test/internal/manifest"
or, itll be imported automatically if you use "github.com/Microsoft/hcsshim/test/internal/require".Build(osversion.V21H1), itll manifest the exe automatically.
There was a problem hiding this comment.
We should plop a syso in here as ncproxy should probably be manifested anyways
There was a problem hiding this comment.
I used go-winres to add the syso files. @dcantah could you verify if it looks valid?
|
Merge conflict on our pal go.sum |
katiewasnothere
force-pushed
the
ipv6_ncproxy
branch
from
83e4af3
to
44011e4
Compare
|
The supportedOS bits list Windows 7 and 8 which this definitely won't run on but not the end of the world, as long as osversion returns the right build I'm fine with this |
katiewasnothere
force-pushed
the
ipv6_ncproxy
branch
2 times, most recently
from
d6f2743
to
ba416d5
Compare
|
@katiewasnothere Can we fix the conflicts and get this in? |
* Update proto file and dependencies * Update hcn code paths to return dual stack info * Update hcn ncproxy tests with dual stack scenarios Signed-off-by: Kathryn Baldauf <kabaldau@microsoft.com>
Signed-off-by: Kathryn Baldauf <kabaldau@microsoft.com>
katiewasnothere
force-pushed
the
ipv6_ncproxy
branch
from
ba416d5
to
e4d9824
Compare
Signed-off-by: Kathryn Baldauf kabaldau@microsoft.com