Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[test]Add feature for CRI extensions #1565

Merged
merged 1 commit into from
Nov 17, 2022
Merged

[test]Add feature for CRI extensions #1565

merged 1 commit into from
Nov 17, 2022

Conversation

helsaawy
Copy link
Contributor

@helsaawy helsaawy commented Nov 17, 2022 •
edited
Loading

Add feature flag CRIPlugin to gate tests that use non-standard CRI API calls or plugins, so that they are not always run by default

Signed-off-by: Hamza El-Saawy hamzaelsaawy@microsoft.com

@helsaawy
[test]Add feature for CRI plugins
d1e9d5a 
Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>
@helsaawy helsaawy requested a review from a team as a code owner November 17, 2022 22:08
@kevpar
Copy link
Member

kevpar commented Nov 17, 2022

Can you please use the common form test: Add feature... for the commit/PR description?

What is this new feature flag intended to do?

@helsaawy helsaawy merged commit f83cc58 into microsoft:main Nov 17, 2022
@helsaawy helsaawy deleted the azcri-feature branch November 17, 2022 22:29
@helsaawy
Copy link
Contributor Author

I just saw this comment, sorry
And it prevents running the CRI restart API tests (until we move those tests out of this repo to the ADO AzCRI repo)

anmaxvl pushed a commit that referenced this pull request Feb 7, 2023
@kiashok
Merged PR 7167661: Update ADO hcsshim from github repo
be52222 
Updating the ADO repo from github hcsshim

Last commit - f83cc58

Related work items: #1536, #1562, #1563, #1564, #1565
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiashok kiashok kiashok approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@helsaawy @kevpar @kiashok