rego: fix slightly incorrect sandbox and hugepage mounts enforcement #1625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matajoh
reviewed
Jan 27, 2023
| @@ -57,10 +59,10 @@ func securityPolicyFromContainers( | |||
| return base64.StdEncoding.EncodeToString([]byte(policyString)), nil | |||
| } | |||
|
|
|||
| func sandboxSecurityPolicy(t *testing.T, policyType string, allowEnvironmentVariableDropping bool) string { | |||
There was a problem hiding this comment.
Why remove this test element? Couldn't both be varied, i.e. unencrypted scratch and env dropping?
There was a problem hiding this comment.
Just looking at the code, it seemed like there was a bad rebase. I don't sandboxSecurityPolicy is used anywhere with allow env var dropping... the only places where that parameter is used is in encrypted scratch tests.
helsaawy
approved these changes
Jan 27, 2023
Sandbox and hugepage mounts come via CRI config in the form: `sandbox://<absolute-path>`, however the existing enforcement and tests expect it to be `sandbox://<relative-path>` which causes a problem during mount enforcement, when the sandbox prefix is replaced with an additional path separator in the end. Additionally update policy tests. Signed-off-by: Maksim An <maksiman@microsoft.com>
anmaxvl
force-pushed
the
fix/sandbox-hugepage-dirs-rego
branch
from
29c1096
to
912f789
Compare
princepereira
pushed a commit
to princepereira/hcsshim
that referenced
this pull request
Aug 29, 2024
…icrosoft#1625) Sandbox and hugepage mounts come via CRI config in the form: `sandbox://<absolute-path>`, however the existing enforcement and tests expect it to be `sandbox://<relative-path>` which causes a problem during mount enforcement, when the sandbox prefix is replaced with an additional path separator in the end. Additionally update policy tests. Signed-off-by: Maksim An <maksiman@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sandbox and hugepage mounts come via CRI config in the form:
sandbox://<absolute-path>, however the existing enforcement and tests expect it to besandbox://<relative-path>which causes a problem during mount enforcement, when the sandbox prefix is replaced with an additional path separator in the end.Additionally update policy tests.
Signed-off-by: Maksim An maksiman@microsoft.com