[release/0.9] Backport test/pkg directory
#1913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Backport testing support functions in the `test/pkg` directory. This includes changes from: - microsoft#1536 - microsoft#1704 - microsoft#1853 - microsoft#1893 Rather than cherry-pick them, only changes to `test/pkg` are included, since tests themselves will require significant changes to bring up-to-date. The goal is to expose testing functions so that tests can be moved out of the repo. Updated go version in `test` to 1.8, as required by `test/pkg/flag`. Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>
anmaxvl
approved these changes
Sep 27, 2023
yyatmsft
reviewed
Sep 27, 2023
| @@ -0,0 +1,10 @@ | |||
| <?xml version="1.0" encoding="UTF-8" standalone="yes"?> | |||
| <assembly xmlns="urn:schemas-microsoft-com:asm.v1" manifestVersion="1.0"> | |||
| <description>containerd-shim-runhcs-v1</description> | |||
There was a problem hiding this comment.
i totally missed that when i made the original PR
since its also in main, id rather get in a PR to main first that updates the description, then backport that to 0.9 and 0.11, if thats allright
There was a problem hiding this comment.
Yeah back porting makes more sense
yyatmsft
approved these changes
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport testing support functions in the
test/pkgdirectory. This includes changes from:Rather than cherry-pick them, only changes to
test/pkgare included, since tests themselves will require significant changes to bring up-to-date.The goal is to expose testing functions so that tests can be moved out of the repo.
Updated go version in
testto 1.8, as required bytest/pkg/flag.