Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update newBinaryCmd URL path handling #2041

Merged
merged 1 commit into from
Feb 28, 2024
Merged

update newBinaryCmd URL path handling #2041

merged 1 commit into from
Feb 28, 2024

Commits on Feb 28, 2024

  1. update newBinaryCmd URL path handling

    Windows UNC paths weren't properly handled by `filepath.Clean` and
    this behavior was fixed in golang/go@be9d78c
    
    For a binary URL `binary:///\executable`, the `URL.Path` will be
    `/\executable` and `filepath.Clean` will now return `\\executable`,
    which previously would return `\executable`.
    In the case of binary logger, it'd be safer to not accept UNC paths,
    so this PR adds a short circuit when the clean path starts with `\\`.
    
    Signed-off-by: Maksim An <maksiman@microsoft.com>
    anmaxvl committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    ceb2ef5 View commit details
    Browse the repository at this point in the history