Add LCOW rootfs as pmem/vhd as option; Config for no scsi and number of VPMem #240
Conversation
functional/lcow_test.go
Outdated
| OperatingSystem: "linux", | ||
| ID: "uvm", | ||
| VPMemDeviceCount: 1, | ||
| NoSCSI: true, |
There was a problem hiding this comment.
Should we expose it this way? When we support multiple controllers a single boolean wont suffice
There was a problem hiding this comment.
Sure, will update to *int where nil means 1 by default.
functional/lcow_test.go
Outdated
| t.Fatal(err) | ||
| } | ||
| defer lcowUVM.Terminate() | ||
| out, err := exec.Command(`hcsdiag`, `exec`, `-uvm`, lcowUVM.ID(), `dmesg`).Output() |
There was a problem hiding this comment.
I dont know this infra very well yet. Why are we using hcsdiag and not use the HCS CreateProcess call ourselves?
There was a problem hiding this comment.
It's a temporary hack. I'll add a TODO here.
| } | ||
|
|
||
| fmt.Printf("- Creating %s...\n", destFile) | ||
| if _, err := exec.Command(`powershell`, `-command`, fmt.Sprintf(`New-VHD %s -SizeBytes %dMB -fixed`, destFile, c.Int("s"))).Output(); err != nil { |
There was a problem hiding this comment.
This wont work on all machines. Should we do this via the storage api's instead?
There was a problem hiding this comment.
Again, temporary hack. I'll add a TODO here. Ideally I should extend go-winio to be able to create fixed disks under 1GB.
internal/uvm/create.go
Outdated
| type PreferredRootFSType int | ||
|
|
||
| const ( | ||
| PreferredRootFSTypeDefault = 0 |
There was a problem hiding this comment.
I don't like code like this. Default means you have to have some IF that transforms the code into initrd or vhd based on some case (by default). Why not just start InitRd = 0 so it is the default and if you want VHD you have to specify it
internal/uvm/create.go
Outdated
| EnableGraphicsConsole bool // If true, enable a graphics console for the utility VM | ||
| ConsolePipe string // The named pipe path to use for the serial console. eg \\.\pipe\vmpipe | ||
| VPMemDeviceCount int32 // Number of VPMem devices. Limit at 128. If booting UVM from VHD, device 0 is taken. | ||
| NoSCSI bool // The utility VM does not have any SCSI controllers. Useful in some service VM scenarios. |
There was a problem hiding this comment.
Same as my comment above. How about SCSICount: 0, 1, 2 etc.
internal/uvm/create.go
Outdated
| hcsDocument.VirtualMachine.Devices.VPMem.Devices = make(map[string]schema2.VirtualMachinesResourcesStorageVpmemDeviceV2) | ||
| imageFormat := "VHD1" | ||
| if strings.ToLower(filepath.Ext(opts.RootFSFile)) == "vhdx" { | ||
| imageFormat = "VHD2" |
There was a problem hiding this comment.
The schema doesnt look like it even supports VHD2 here
There was a problem hiding this comment.
It does. It's Default 😕
Signed-off-by: John Howard <jhoward@microsoft.com>
lowenna
force-pushed
the
jjh/pmemboottestnotinitrd
branch
from
b93bdea
to
d3cc9bb
Compare
Signed-off-by: John Howard <jhoward@microsoft.com>
lowenna
force-pushed
the
jjh/pmemboottestnotinitrd
branch
from
d3cc9bb
to
7addede
Compare
Signed-off-by: John Howard jhoward@microsoft.com
Fixes #205. @jstarks @jterry75
build.ps1in the Microsoft/opengcs repo into a rootfs.vhd file.createuvm.go