Add open census spans for ncproxy + go mod vendor #966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We should make sure we have the |
|
@kevpar I think I have the ttrpc ones handled, but I don't for grpc |
dcantah
force-pushed
the
ncproxy-oc
branch
2 times, most recently
from
86eb619
to
bb6e20f
Compare
kevpar
reviewed
Mar 12, 2021
cmd/ncproxy/main.go
Outdated
| @@ -50,7 +67,12 @@ func main() { | |||
| if conf.NodeNetSvcAddr != "" { | |||
| log.G(ctx).Debugf("connecting to NodeNetworkService at address %s", conf.NodeNetSvcAddr) | |||
|
|
|||
| opts := []grpc.DialOption{grpc.WithInsecure()} | |||
| // Register views to collect data. | |||
| if err := view.Register(ocgrpc.DefaultClientViews...); err != nil { | |||
There was a problem hiding this comment.
I don't think we need this, don't use any stats stuff anywhere.
There was a problem hiding this comment.
KK wasn't sure. Just followed the example they gave
There was a problem hiding this comment.
Wait, do we just not want the views registered or the interceptor at all?
There was a problem hiding this comment.
We need the GRPC handler registered, just not the view.Register thing.
dcantah
force-pushed
the
ncproxy-oc
branch
2 times, most recently
from
e50feb3
to
eaa6acb
Compare
dcantah
changed the title
dcantah
changed the title
* Give ncproxy its own etw provider * Add open census spans around all of the ncproxy calls * Go mod vendor + tidy to bring in go.opencensus.io/plugin and go.opencensus.io/stats Signed-off-by: Daniel Canter <dcanter@microsoft.com>
dcantah
changed the title
|
Ok last rename I swear 😆 |
anmaxvl
pushed a commit
to anmaxvl/hcsshim
that referenced
this pull request
Aug 19, 2021
This PR updates our internal ADO repo to the github commit [d9474d2](microsoft@d9474d2). Related work items: microsoft#964, microsoft#965, microsoft#966, microsoft#967, microsoft#968, microsoft#969, microsoft#970, microsoft#971, microsoft#972, microsoft#974, microsoft#975, microsoft#976, microsoft#977, microsoft#978, microsoft#979, microsoft#980, microsoft#981, microsoft#982, microsoft#983, microsoft#984, microsoft#987, microsoft#990, microsoft#991, microsoft#992, microsoft#993, microsoft#995, microsoft#996, microsoft#997, microsoft#1000
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Daniel Canter dcanter@microsoft.com