Fix stderr comment in containerd-shim serve command #995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In a comment in the serve command for the containerd-shim it says that to signify that we're successfully serving the ttrpc endpoint we should close stderr, but we actually close stdout to signify this. The write end of the pipe is hooked up to stdout on the "serve" command invocation of the shim and we simply forward stderr to the read side until close. Stderr for the serve invocation is hooked up to the panic.log file in case the shim panics. Signed-off-by: Daniel Canter <dcanter@microsoft.com>
anmaxvl
approved these changes
Apr 8, 2021
anmaxvl
pushed a commit
to anmaxvl/hcsshim
that referenced
this pull request
Aug 19, 2021
This PR updates our internal ADO repo to the github commit [d9474d2](microsoft@d9474d2). Related work items: microsoft#964, microsoft#965, microsoft#966, microsoft#967, microsoft#968, microsoft#969, microsoft#970, microsoft#971, microsoft#972, microsoft#974, microsoft#975, microsoft#976, microsoft#977, microsoft#978, microsoft#979, microsoft#980, microsoft#981, microsoft#982, microsoft#983, microsoft#984, microsoft#987, microsoft#990, microsoft#991, microsoft#992, microsoft#993, microsoft#995, microsoft#996, microsoft#997, microsoft#1000
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a comment in the serve command for the containerd-shim it says that to signify that we're
successfully serving the ttrpc endpoint we should close stderr, but we actually seem to close stdout
to signify this. The write end of the pipe is hooked up to stdout on the "serve" command invocation
of the shim and we simply forward stderr to the read side until close. Stderr for the serve
invocation is hooked up to the panic.log file
Signed-off-by: Daniel Canter dcanter@microsoft.com