Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: Use custom checkpoint for test stage in DeepMIL #318

Merged
merged 8 commits into from
Apr 21, 2022
Merged

BUG: Use custom checkpoint for test stage in DeepMIL #318

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
a9a1a52
cleanup of checkpoint handling
ant0nsc Apr 20, 2022
4fa6523
template for new method
ant0nsc Apr 20, 2022
55e462c
Merge branch 'antonsc/best_checkpoint' of https://github.com/microsof…
Apr 20, 2022
be3162e
refactoring to avoid circular import
ant0nsc Apr 20, 2022
e65ff87
doc
ant0nsc Apr 20, 2022
84b7af7
rename basemil method
Apr 20, 2022
002a02e
Merge branch 'antonsc/best_checkpoint' of https://github.com/microsof…
Apr 20, 2022
2a8c0fe
merge latest changes
Apr 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion hi-ml-histopathology/src/histopathology/configs/classification/BaseMIL.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,7 @@ def get_dataloader_kwargs(self) -> dict:
def get_callbacks(self) -> List[Callback]:
return super().get_callbacks() + [self.callbacks]

def get_path_to_best_checkpoint(self) -> Path:
def get_checkpoint_to_test(self) -> Path:
"""
Returns the full path to a checkpoint file that was found to be best during training, whatever criterion
was applied there. This is necessary since for some models the checkpoint is in a subfolder of the checkpoint
Expand Down