-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: Run WSI pipeline at scale. #357
Conversation
Codecov Report
@@ Coverage Diff @@
## main #357 +/- ##
==========================================
- Coverage 80.86% 75.39% -5.48%
==========================================
Files 28 51 +23
Lines 2383 2999 +616
Branches 352 412 +60
==========================================
+ Hits 1927 2261 +334
- Misses 354 661 +307
+ Partials 102 77 -25
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good from a code perspective. Now that we have the pipeline running, I'd love to see more details around the impact of the changes individually: Spawn alone, uint8 alone.
hi-ml-histopathology/src/histopathology/configs/classification/DeepSMILEPanda.py
Show resolved
Hide resolved
"at level 1.") | ||
|
||
# Outputs Handler parameters: | ||
save_tiles: bool = param.Boolean(True, doc="a boolean parameter to enable 'save_top_and_bottom_tiles' and" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small suggestion save_output_tiles
might be a bit more interpretable. From a first read I thought this was about saving all the randomly sampled tiles
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good point!
Small Fixes to make the WSI run at scale for PANDA cohort. Main changes: