Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Run WSI pipeline at scale. #357

Merged
merged 16 commits into from
May 20, 2022
Merged

Conversation

kenza-bouzid
Copy link
Contributor

Small Fixes to make the WSI run at scale for PANDA cohort. Main changes:

  • fix all parameters of PandaSlidesDataModule to avoid default behaviors
  • set multiprocessing_context to "spawn" for WSI container
  • add parameter save_tiles to outputs handler

@codecov
Copy link

codecov bot commented May 18, 2022

Codecov Report

Merging #357 (07936d4) into main (325384b) will decrease coverage by 5.47%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##             main     #357      +/-   ##
==========================================
- Coverage   80.86%   75.39%   -5.48%     
==========================================
  Files          28       51      +23     
  Lines        2383     2999     +616     
  Branches      352      412      +60     
==========================================
+ Hits         1927     2261     +334     
- Misses        354      661     +307     
+ Partials      102       77      -25     
Impacted Files Coverage Δ
...logy/src/histopathology/datamodules/base_module.py 78.32% <ø> (ø)
...pathology/src/histopathology/utils/output_utils.py 50.00% <12.50%> (ø)
...c/histopathology/configs/classification/BaseMIL.py 65.86% <33.33%> (ø)
...pathology/configs/classification/DeepSMILEPanda.py 70.42% <66.66%> (ø)
...istopathology/src/histopathology/models/deepmil.py 90.96% <80.00%> (ø)
hi-ml/src/health_ml/utils/__init__.py
hi-ml/src/health_ml/utils/config_loader.py
hi-ml/src/health_ml/utils/lr_scheduler.py
hi-ml/src/health_ml/model_trainer.py
hi-ml/src/health_ml/utils/data_augmentations.py
... and 74 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 325384b...07936d4. Read the comment docs.

Copy link
Collaborator

@ant0nsc ant0nsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good from a code perspective. Now that we have the pipeline running, I'd love to see more details around the impact of the changes individually: Spawn alone, uint8 alone.

@kenza-bouzid kenza-bouzid merged commit f67ea46 into main May 20, 2022
@kenza-bouzid kenza-bouzid deleted the kenzab/run_scalable_wsi_pipeline branch May 20, 2022 08:58
"at level 1.")

# Outputs Handler parameters:
save_tiles: bool = param.Boolean(True, doc="a boolean parameter to enable 'save_top_and_bottom_tiles' and"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small suggestion save_output_tiles might be a bit more interpretable. From a first read I thought this was about saving all the randomly sampled tiles

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants