Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase control width to avoid truncating text #13

Merged
merged 1 commit into from Oct 17, 2019

Conversation

@bhank
Copy link
Contributor

bhank commented Oct 16, 2019

The text change in 887301d from "Updating VS Code..." to "Updating Visual Studio Code..." made it wide enough to be truncated and only show "Updating Visual".

This PR gives the text control the same width as the progress bar. It should fix microsoft/vscode#81433 .

I have only tested it in a resource editor, and not by actually building and running the updater.

@joaomoreno

This comment has been minimized.

Copy link
Member

joaomoreno commented Oct 17, 2019

Oh that's what that was! Great fix, thanks!

@joaomoreno joaomoreno self-assigned this Oct 17, 2019
@joaomoreno joaomoreno merged commit 0f17bfa into microsoft:master Oct 17, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
license/cla All CLA requirements met.
@joaomoreno joaomoreno added this to the October milestone Nov 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.