Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update NPM instructions. #112

Merged
merged 2 commits into from
Jun 17, 2021
Merged

Update NPM instructions. #112

merged 2 commits into from
Jun 17, 2021

Conversation

ms-teli
Copy link
Contributor

@ms-teli ms-teli commented Jun 17, 2021

No description provided.

@ms-teli ms-teli marked this pull request as ready for review June 17, 2021 18:18
@namalu
Copy link
Member

namalu commented Jun 17, 2021

The project doesn't build in Visual Studio because there are 2 missing project references: Microsoft.Health.Logging and Microsoft.Health.Events

@ms-teli
Copy link
Contributor Author

ms-teli commented Jun 17, 2021

The project doesn't build in Visual Studio because there are 2 missing project references: Microsoft.Health.Logging and Microsoft.Health.Events

Thanks for pointing out. Verified the error.

Yes, the project references are missing in the solution. Let me try to add them in another PR.

@ms-teli ms-teli merged commit 4bfcdb7 into master Jun 17, 2021
@dustinburson dustinburson deleted the personal/teli/update-npm-instructions branch November 8, 2022 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dustinburson dustinburson dustinburson approved these changes

Assignees

@rbhaiya rbhaiya

@namalu namalu

@dustinburson dustinburson

@msjasteppe msjasteppe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ms-teli @namalu @dustinburson @rbhaiya @msjasteppe