Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FHIR versioning handling strategy to take its selection in template from customer, as well as update the instruction documents. #49

Merged
merged 1 commit into from
Jun 29, 2020

Conversation

ms-teli
Copy link
Contributor

@ms-teli ms-teli commented Jun 26, 2020

Add FHIR versioning handling strategy to take its selection in template from customer, as well as update the instruction documents.

Test Result

Support Test Result
Managed identity deployment Succeeded
Un-managed identity deployment Succeeded
Sandbox deployment Succeeded
Docker Succeeded
Local VS Succeeded

template and propage to all the dev supports.
@ms-teli ms-teli marked this pull request as ready for review June 26, 2020 00:38
Copy link
Member

@dustinburson dustinburson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting approach. We can proceed with this for now but feel we may need to adjust further when we actually implement the R5 libraries.

@@ -12,6 +12,9 @@
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
<WarningsAsErrors />
</PropertyGroup>
<PropertyGroup>
<FhirVersion Condition="'$(FhirVersion)' == ''">R4</FhirVersion>
Copy link
Member

@dustinburson dustinburson Jun 26, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is interesting but not sure I like this. Would prefer having a separate project for R4 and R5 that way both solutions could be open at the same time. This also in the PR and CI builds will only compile against the R4 version. Once we add R5 support we will want to make sure both versions are compiled. It can stay as is but I think will need to be adjusted when we do add R5 support.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reviewing. One tradeoff of creating a separate project for different FHIR versions is that we will likely have to duplicate all the functions' code in the new projects. In my tests, I found that the Azure Function only scans the function entry-point attributes in the start up Assembly, not in all its dependencies. I've not gotten a clear answer yet of whether it's no or it's possible to register the assembly to let the framework scan in some way. Let's review this topic when the R5 work comes up again. Meantime, I'll reach out to broader Azure community to find something.

@ms-teli ms-teli merged commit 7ccbc6c into master Jun 29, 2020
@dustinburson dustinburson deleted the personal/teli/fhir-versioning branch November 8, 2022 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants