Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

status code report #91

Merged
merged 7 commits into from
Dec 1, 2020
Merged

status code report #91

merged 7 commits into from
Dec 1, 2020

Conversation

pelikhan
Copy link
Member

@pelikhan pelikhan commented Nov 30, 2020 •
edited
Loading

Report for errors.

@pelikhan pelikhan mentioned this pull request Nov 30, 2020
Closed
@mmoskal
Copy link
Member

mmoskal commented Dec 1, 2020

Hmm... wait; it was supposed to be in _base not control?

@pelikhan
Copy link
Member Author

pelikhan commented Dec 1, 2020

Right... moved.

@pelikhan
Copy link
Member Author

pelikhan commented Dec 1, 2020

  • rename _base to _system
  • move status_code to _base
  • implicit extends from _base for all services
  • store class name derived - super.

@pelikhan
Copy link
Member Author

pelikhan commented Dec 1, 2020

@mmoskal moved away from enum in statuscode as we seem to duplicate it in every service.

@pelikhan pelikhan requested a review from mmoskal December 1, 2020 09:57
@pelikhan pelikhan merged commit 407d9cd into main Dec 1, 2020
@pelikhan pelikhan deleted the errorreport branch December 1, 2020 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmoskal mmoskal Awaiting requested review from mmoskal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pelikhan @mmoskal