Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump coverlet.msbuild from 6.0.0 to 6.0.1 #173

Merged
merged 2 commits into from Feb 21, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Feb 21, 2024

Bumps coverlet.msbuild from 6.0.0 to 6.0.1.

Release notes

Sourced from coverlet.msbuild's releases.

v6.0.1

Fixed

  • Uncovered lines in .NET 8 for inheriting records #1555
  • Fix record constructors not covered when SkipAutoProps is true #1561
  • Fix .NET 7 Method Group branch coverage issue #1447
  • Fix ExcludeFromCodeCoverage does not exclude method in a partial class #1548
  • Fix ExcludeFromCodeCoverage does not exclude F# task #1547
  • Fix issues where ExcludeFromCodeCoverage ignored #1431
  • Fix issues with ExcludeFromCodeCoverage attribute #1484
  • Fix broken links in documentation #1514
  • Fix problem with coverage for .net5 WPF application #1221 by https://github.com/lg2de
  • Fix unable to instrument module for Microsoft.AspNetCore.Mvc.Razor #1459 by https://github.com/lg2de

Improvements

Diff between 6.0.0 and 6.0.1

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@baywet
Copy link
Member

baywet commented Feb 21, 2024

@dependabot rebase

Bumps [coverlet.msbuild](https://github.com/coverlet-coverage/coverlet) from 6.0.0 to 6.0.1.
- [Release notes](https://github.com/coverlet-coverage/coverlet/releases)
- [Commits](coverlet-coverage/coverlet@v6.0.0...v6.0.1)

---
updated-dependencies:
- dependency-name: coverlet.msbuild
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/nuget/coverlet.msbuild-6.0.1 branch from 8ff814b to a222788 Compare February 21, 2024 12:19
@andrueastman
Copy link
Member

I think we will have to close this one for now. Looks like this update is breaking on coverage collection for the nefx tests. Related to coverlet-coverage/coverlet#1625

auto-merge was automatically disabled February 21, 2024 15:22

Pull request was closed

Copy link
Contributor Author

dependabot bot commented on behalf of github Feb 21, 2024

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@andrueastman andrueastman deleted the dependabot/nuget/coverlet.msbuild-6.0.1 branch February 21, 2024 15:22
@andrueastman andrueastman restored the dependabot/nuget/coverlet.msbuild-6.0.1 branch February 21, 2024 15:24
@andrueastman andrueastman reopened this Feb 21, 2024
Copy link

sonarcloud bot commented Feb 21, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@baywet
Copy link
Member

baywet commented Feb 21, 2024

I can see that you've already removed the dependency as a test. Hopefully that solves the issue, if it doesn't we could alternatively only require coverage on the net8 runs (would require editing the workflow definition)

@baywet baywet merged commit 0c9cfe8 into main Feb 21, 2024
8 of 10 checks passed
@baywet baywet deleted the dependabot/nuget/coverlet.msbuild-6.0.1 branch February 21, 2024 15:33
@andrueastman
Copy link
Member

Looks like the right thing to do here is to drop it. According to the docs, we shouldn't be having both dependencies together.

https://github.com/coverlet-coverage/coverlet?tab=readme-ov-file#installation-coverletmsbuild

Lemme update the other PRs and resolve as well.

@baywet
Copy link
Member

baywet commented Feb 21, 2024

Wait, see #175
Since we dropped the dependency we don't have coverage information anymore.
Before we start replicating things, I'd like to make sure we get it right.

@andrueastman
Copy link
Member

Seen it now. Let me double check things a bit first.

if it doesn't we could alternatively only require coverage on the net8 runs (would require editing the workflow definition)

Otherwise, we can then try out the suggestion here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants