-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
splits authentication and access token interfaces for go, java, dotnet and docs #1050
splits authentication and access token interfaces for go, java, dotnet and docs #1050
Conversation
abstractions/go/authentication/base_bearer_token_authentication_provider.go
Show resolved
Hide resolved
I don't have historical context as to why we have |
@jobala to answer your question it's just a branding/convenience naming. |
In this case we should consider omitting |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe we still need to bump up the version numbers for the abstractions/authentication packages to avoid any issues during release
We do, I'm planning to do that in #1039 once all other PRs are merged into it |
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, my only reservation is with having AzureIdentity in function, method and struct names in the Go components of this PR.
@jobala thanks for taking the time to review it. And that reservation is because the name is getting long? |
completion of #1039
CC @Ndiritu @SilasKenneth when you move on to implementing azure authentication provider for PHP, and to update your abstractions as well.