Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeScript - CJS/ES set up #991

Merged
merged 34 commits into from
Jan 28, 2022
Merged

TypeScript - CJS/ES set up #991

merged 34 commits into from
Jan 28, 2022

Conversation

nikithauc
Copy link
Contributor

@nikithauc nikithauc commented Jan 4, 2022

fixes #272
fixes #841
fixes #1072
fixes #729

Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for taking this on, a few minor comments.

abstractions/typescript/package.json Outdated Show resolved Hide resolved
abstractions/typescript/tsconfig.base.json Show resolved Hide resolved
@baywet baywet added the TypeScript Pull requests that update Javascript code label Jan 4, 2022
@baywet baywet added this to the TypeWriter Replacement milestone Jan 4, 2022
baywet
baywet previously approved these changes Jan 27, 2022
@baywet
Copy link
Member

baywet commented Jan 27, 2022

@nikithauc let me know when you're ready to merge so I can override the policies for you.
also can I suggest we rebase #1077, #993 and #992 onto this one, and merge them in here before we merge this to reduce the number of releases?

@nikithauc
Copy link
Contributor Author

@nikithauc let me know when you're ready to merge so I can override the policies for you. also can I suggest we rebase #1077, #993 and #992 onto this one, and merge them in here before we merge this to reduce the number of releases?

Good idea! Let me try that.

baywet
baywet previously approved these changes Jan 28, 2022
@baywet
Copy link
Member

baywet commented Jan 28, 2022

@nikithauc thanks for the extended collaboration on all of that! I think we're good to merge. Just let me know when you'd like me to override the branch policies. The sooner the better so we don't run into conflicts again. I also closed the other PRs for sanity (but didn't delete the branches yet).

@sonarcloud
Copy link

sonarcloud bot commented Jan 28, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

92.9% 92.9% Coverage
0.0% 0.0% Duplication

@nikithauc
Copy link
Contributor Author

@nikithauc thanks for the extended collaboration on all of that! I think we're good to merge. Just let me know when you'd like me to override the branch policies. The sooner the better so we don't run into conflicts again. I also closed the other PRs for sanity (but didn't delete the branches yet).

Good to merge!

@baywet baywet merged commit b81bc6d into main Jan 28, 2022
@baywet baywet deleted the nikithauc/cjs-es branch January 28, 2022 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TypeScript Pull requests that update Javascript code
Projects
Archived in project
2 participants