-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TypeScript - CJS/ES set up #991
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for taking this on, a few minor comments.
@nikithauc let me know when you're ready to merge so I can override the policies for you. |
Good idea! Let me try that. |
@nikithauc thanks for the extended collaboration on all of that! I think we're good to merge. Just let me know when you'd like me to override the branch policies. The sooner the better so we don't run into conflicts again. I also closed the other PRs for sanity (but didn't delete the branches yet). |
Kudos, SonarCloud Quality Gate passed! |
Good to merge! |
fixes #272
fixes #841
fixes #1072
fixes #729