Skip to content

Commit

Permalink
[R-package] Fix build_r.R failing in Windows (#1694)
Browse files Browse the repository at this point in the history
* Fix #1693

* Fix spacing

* Fr -> For

* Recursive causes error on strict R environments
  • Loading branch information
Laurae2 authored and jameslamb committed Sep 23, 2018
1 parent 577a03c commit 2a39b70
Showing 1 changed file with 31 additions and 44 deletions.
75 changes: 31 additions & 44 deletions build_r.R
@@ -1,4 +1,4 @@
# for macOS users who have decided to use gcc
# For macOS users who have decided to use gcc
# (replace 8 with version of gcc installed on your machine)
# NOTE: your gcc / g++ from Homebrew is probably in /usr/local/bin
#export CXX=/usr/local/bin/g++-8 CC=/usr/local/bin/gcc-8
Expand All @@ -7,76 +7,63 @@

# R returns FALSE (not a non-zero exit code) if a file copy operation
# breaks. Let's fix that
.handle_result <- function(res){
if (!res){
stop("Copying files failed!")
}
.handle_result <- function(res) {
if (!res) {
stop("Copying files failed!")
}
}

# Make a new temporary folder to work in
unlink(x = "lightgbm_r", recursive = TRUE)
dir.create("lightgbm_r")

# copy in the relevant files
result <- file.copy(
from = "R-package/./"
, to = "lightgbm_r/"
, recursive = TRUE
, overwrite = TRUE
)
result <- file.copy(from = "R-package/./",
to = "lightgbm_r/",
recursive = TRUE,
overwrite = TRUE)
.handle_result(result)

result <- file.copy(
from = "include/"
, to = file.path("lightgbm_r", "src/")
, recursive = TRUE
, overwrite = TRUE
)
result <- file.copy(from = "include/",
to = file.path("lightgbm_r", "src/"),
recursive = TRUE,
overwrite = TRUE)
.handle_result(result)

result <- file.copy(
from = "src/"
, to = file.path("lightgbm_r", "src/")
, recursive = TRUE
, overwrite = TRUE
)
result <- file.copy(from = "src/",
to = file.path("lightgbm_r", "src/"),
recursive = TRUE,
overwrite = TRUE)
.handle_result(result)

result <- file.copy(
from = "CMakeLists.txt"
, to = file.path("lightgbm_r", "inst", "bin/")
, recursive = TRUE
, overwrite = TRUE
)
result <- file.copy(from = "CMakeLists.txt",
to = file.path("lightgbm_r", "inst", "bin/"),
overwrite = TRUE)
.handle_result(result)

# rebuild documentation
devtools::document(
pkg = "lightgbm_r/"
)
devtools::document(pkg = "lightgbm_r")

# Build the package
# NOTE: --keep-empty-dirs is necessary to keep the deep paths expected
# by CMake while also meeting the CRAN req to create object files
# on demand
devtools::build(
pkg = "lightgbm_r"
, args = c("--keep-empty-dirs")
)
devtools::build(pkg = "lightgbm_r",
args = c("--keep-empty-dirs"))

# Install the package
version <- gsub(
"Version: "
, ""
, grep(
"Version: "
, readLines(con = file.path("lightgbm_r", "DESCRIPTION"))
, value = TRUE
)
"Version: ",
"",
grep(
"Version: ",
readLines(con = file.path("lightgbm_r", "DESCRIPTION")),
value = TRUE
)
)
tarball <- file.path(getwd(), sprintf("lightgbm_%s.tar.gz", version))

system(sprintf("R CMD INSTALL %s --no-multi-arch", tarball))

# Run R CMD CHECK
#R CMD CHECK lightgbm_2.1.2.tar.gz --as-cran | tee check.log | cat
# R CMD CHECK lightgbm_2.1.2.tar.gz --as-cran | tee check.log | cat

0 comments on commit 2a39b70

Please sign in to comment.