Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for QEMU/libvirt platform. #1677

Merged
merged 2 commits into from
Jan 19, 2022

Conversation

cwize1
Copy link
Contributor

@cwize1 cwize1 commented Jan 4, 2022

Add basic support for running LISA framework on Linux platform
using QEMU via the libvirt API. This includes succesfully running
the Microsoft T0 tests against the CBL-Mariner image.

@cwize1 cwize1 marked this pull request as draft January 4, 2022 23:11
@squirrelsc
Copy link
Member

We manage commits to reflect the code changes in history. It needs each commit is meaningful and independent (well, it looks like at least). Please try to use git add/reset -p, git rebase -i origin/main and other commands to pick, sort the changes. For some big change like init a platform, it doesn't need a separated change. But for some changes, which involves the platform, it's better to make it meaningful, and small.

lisa/util/constants.py Outdated Show resolved Hide resolved
@cwize1
Copy link
Contributor Author

cwize1 commented Jan 4, 2022

We manage commits to reflect the code changes in history. It needs each commit is meaningful and independent (well, it looks like at least). Please try to use git add/reset -p, git rebase -i origin/main and other commands to pick, sort the changes. For some big change like init a platform, it doesn't need a separated change. But for some changes, which involves the platform, it's better to make it meaningful, and small.

Fair.

@cwize1 cwize1 closed this Jan 5, 2022
@cwize1 cwize1 reopened this Jan 5, 2022
@cwize1 cwize1 marked this pull request as ready for review January 5, 2022 19:30
lisa/util/package.py Outdated Show resolved Hide resolved
lisa/util/package.py Outdated Show resolved Hide resolved
@cwize1 cwize1 marked this pull request as draft January 7, 2022 22:32
@cwize1 cwize1 force-pushed the user/chrisgun/Qemu branch 2 times, most recently from ef5643c to 1030c06 Compare January 11, 2022 22:02
@cwize1 cwize1 marked this pull request as ready for review January 11, 2022 22:03
Add basic support for running LISA framework on Linux platform
using QEMU via the libvirt API. This includes succesfully running
the Microsoft T0 tests against the CBL-Mariner image.
@squirrelsc
Copy link
Member

@cwize1 I see it's not a draft version. how is the progress? is it ready to merge?

@cwize1
Copy link
Contributor Author

cwize1 commented Jan 19, 2022

@cwize1 I see it's not a draft version. how is the progress? is it ready to merge?

Yeah, it's ready to merge (assuming no further comments). Though I do plan on adding additional features (serial console, data disks, etc.) over time.

@squirrelsc
Copy link
Member

@cwize1 I see it's not a draft version. how is the progress? is it ready to merge?

Yeah, it's ready to merge (assuming no further comments). Though I do plan on adding additional features (serial console, data disks, etc.) over time.

Thank you. I will double check if. If there is no other comment, I will approve and merge it.

@squirrelsc
Copy link
Member

BTW, wan you add usage documents of qemu in next PR?

@squirrelsc squirrelsc merged commit fc5638b into microsoft:main Jan 19, 2022
squirrelsc pushed a commit that referenced this pull request Jan 24, 2022
* Add support for QEMU/libvirt platform.

Add basic support for running LISA framework on Linux platform
using QEMU via the libvirt API. This includes succesfully running
the Microsoft T0 tests against the CBL-Mariner image.
@cwize1 cwize1 deleted the user/chrisgun/Qemu branch March 4, 2022 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants