NIC Driver binding refactoring #1682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please add the details in the commit message. The commit message is easier to view in code history. |
squirrelsc
reviewed
Jan 6, 2022
squirrelsc
reviewed
Jan 6, 2022
mcgov
force-pushed
the
mcgov/rebind-fix
branch
from
4b1cd38
to
a81ab3e
Compare
moves uio_hv_generic out of the binding function, hoists it to the initialization function above. The enabling function now checks whether the driver has been loaded or not, it only loads it if it has been loaded already.
mcgov
force-pushed
the
mcgov/rebind-fix
branch
from
a81ab3e
to
dca4d53
Compare
squirrelsc
approved these changes
Jan 6, 2022
squirrelsc
pushed a commit
that referenced
this pull request
Jan 14, 2022
moves uio_hv_generic out of the binding function, hoists it to the initialization function above. The enabling function now checks whether the driver has been loaded or not, it only loads it if it has been loaded already.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
moves uio_hv_generic out of the binding function, hoists it to the initialization function above.
The enabling function now checks whether the driver has been loaded or not, it only loads it if it has been loaded already.