migrate ntttcp test cases. #1698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squirrelsc
reviewed
Jan 18, 2022
squirrelsc
reviewed
Jan 18, 2022
squirrelsc
reviewed
Jan 18, 2022
squirrelsc
reviewed
Jan 18, 2022
squirrelsc
reviewed
Jan 18, 2022
squirrelsc
reviewed
Jan 18, 2022
squirrelsc
reviewed
Jan 18, 2022
squirrelsc
reviewed
Jan 20, 2022
squirrelsc
reviewed
Jan 20, 2022
squirrelsc
reviewed
Jan 20, 2022
squirrelsc
reviewed
Jan 20, 2022
squirrelsc
reviewed
Jan 20, 2022
squirrelsc
reviewed
Jan 20, 2022
LiliDeng
force-pushed
the
lildeng/ntttcp
branch
3 times, most recently
from
ecddd29
to
6d4d7df
Compare
squirrelsc
reviewed
Jan 21, 2022
squirrelsc
reviewed
Jan 21, 2022
squirrelsc
reviewed
Jan 21, 2022
squirrelsc
reviewed
Jan 21, 2022
squirrelsc
reviewed
Jan 21, 2022
LiliDeng
force-pushed
the
lildeng/ntttcp
branch
from
6d4d7df
to
b287b9c
Compare
LiliDeng
force-pushed
the
lildeng/ntttcp
branch
4 times, most recently
from
16acfe1
to
bf66626
Compare
squirrelsc
reviewed
Jan 30, 2022
squirrelsc
reviewed
Feb 2, 2022
squirrelsc
reviewed
Feb 2, 2022
squirrelsc
reviewed
Feb 2, 2022
squirrelsc
reviewed
Feb 2, 2022
LiliDeng
force-pushed
the
lildeng/ntttcp
branch
7 times, most recently
from
a682295
to
35857e4
Compare
squirrelsc
reviewed
Feb 7, 2022
squirrelsc
reviewed
Feb 7, 2022
squirrelsc
reviewed
Feb 7, 2022
squirrelsc
reviewed
Feb 7, 2022
| max_server_threads = 64 | ||
| perf_ntttcp_message_list: List[Any] = [] | ||
| for test_thread in connections: | ||
| if test_thread < max_server_threads: |
There was a problem hiding this comment.
Add comments to explain the relationship of thread and buffer size.
There was a problem hiding this comment.
I am not sure the relationship.
There was a problem hiding this comment.
Nobody knows more than you. The logic set num_threads and buffer_size together. Please try to explain as possible as you can in next PR.
LiliDeng
force-pushed
the
lildeng/ntttcp
branch
from
35857e4
to
1049c76
Compare
LiliDeng
force-pushed
the
lildeng/ntttcp
branch
3 times, most recently
from
76785d9
to
655586a
Compare
LiliDeng
force-pushed
the
lildeng/ntttcp
branch
from
655586a
to
133b89e
Compare
squirrelsc
approved these changes
Feb 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.