-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migrate ntttcp test cases. #1698
Conversation
ecddd29
to
6d4d7df
Compare
6d4d7df
to
b287b9c
Compare
16acfe1
to
bf66626
Compare
a682295
to
35857e4
Compare
max_server_threads = 64 | ||
perf_ntttcp_message_list: List[Any] = [] | ||
for test_thread in connections: | ||
if test_thread < max_server_threads: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add comments to explain the relationship of thread and buffer size.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure the relationship.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nobody knows more than you. The logic set num_threads and buffer_size together. Please try to explain as possible as you can in next PR.
35857e4
to
1049c76
Compare
76785d9
to
655586a
Compare
655586a
to
133b89e
Compare
No description provided.