Log cleanup #1735
Merged
Log cleanup #1735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squirrelsc
reviewed
Feb 10, 2022
cwize1
force-pushed
the
user/chrisgun/LogCleanup
branch
from
d9dd6bb
to
7867cb3
Compare
squirrelsc
reviewed
Feb 12, 2022
1. Expose a `local_node` function on the `Environment` class to make it easy to run commands on the test runner machine. 2. Add a `no_debug_log` option to the `Process.start` function and all of its derivatives. This will allow a caller to prevent output from a process from being written to the DEBUG logs. This is useful for commands with particularly spammy output. (For example, `kubectl get -o yaml`.)
cwize1
force-pushed
the
user/chrisgun/LogCleanup
branch
from
7867cb3
to
19f5f80
Compare
squirrelsc
approved these changes
Feb 15, 2022
lesscodingmorehappiness
pushed a commit
that referenced
this pull request
Feb 15, 2022
* Log cleanup 1. Expose a `local_node` function on the `Environment` class to make it easy to run commands on the test runner machine. 2. Add a `no_debug_log` option to the `Process.start` function and all of its derivatives. This will allow a caller to prevent output from a process from being written to the DEBUG logs. This is useful for commands with particularly spammy output. (For example, `kubectl get -o yaml`.) * Add to Tool and co.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a
local_node_connectto make it easy to run commandsagainst the test runner machine
Add a
no_debug_logoption to theProcess.startfunction andall of its derivatives. This will allow a caller to prevent output
from a process from being written to the DEBUG logs. This is useful
for commands with particularly spammy output. (For example,
kubectl get -o yaml.)