Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make env bad if tcp connection is failed, and other fixes. #1894

Merged
merged 6 commits into from
Apr 20, 2022
Merged

Make env bad if tcp connection is failed, and other fixes. #1894

merged 6 commits into from
Apr 20, 2022

Conversation

squirrelsc
Copy link
Member

No description provided.

@squirrelsc squirrelsc requested review from LiliDeng, dsrivastavv and a team April 20, 2022 16:48
dsrivastavv
dsrivastavv reviewed Apr 20, 2022
View reviewed changes
lisa/testsuite.py Outdated Show resolved Hide resolved
sharsonia
sharsonia reviewed Apr 20, 2022
View reviewed changes
Copy link
Collaborator

@sharsonia sharsonia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nit]There is a typo in the commit header (smot[*k]e_test).

@squirrelsc squirrelsc merged commit 70307d9 into microsoft:main Apr 20, 2022
@squirrelsc squirrelsc deleted the 0420 branch April 20, 2022 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsrivastavv dsrivastavv dsrivastavv left review comments

@sharsonia sharsonia sharsonia approved these changes

@LiliDeng LiliDeng Awaiting requested review from LiliDeng LiliDeng is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@squirrelsc @dsrivastavv @sharsonia