DPDK Hugepages: explicit selection of 1GB or 2MB #2948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcgov
force-pushed
the
mcgov/hugepage-explicit
branch
from
38c1313
to
a24fec4
Compare
mcgov
force-pushed
the
mcgov/hugepage-explicit
branch
from
a24fec4
to
83f01ac
Compare
mcgov
force-pushed
the
mcgov/hugepage-explicit
branch
from
83f01ac
to
73f47a4
Compare
LiliDeng
reviewed
Sep 11, 2023
mcgov
force-pushed
the
mcgov/hugepage-explicit
branch
from
fda030e
to
ef54459
Compare
LiliDeng
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mixing hugepage types can cause inconsistent results, move to explicit selection to allow later 2MB / 1GB tests. Old selection was dynamic based on memory size. This means we mix sizes in some cases and exclude sizes in other cases. Move to explicit selection to enable a t4 test for each specific size.