Distinguish between local NVMEs and remote disks when disc controller type is NVMe #3164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LiliDeng
reviewed
Feb 1, 2024
squirrelsc
reviewed
Feb 1, 2024
squirrelsc
reviewed
Feb 1, 2024
squirrelsc
reviewed
Feb 1, 2024
squirrelsc
reviewed
Feb 1, 2024
squirrelsc
reviewed
Feb 26, 2024
|
@LiliDeng LGTM |
SRIKKANTH
force-pushed
the
smyakam/NVMeSupportForNVMeDiskControlledVMs
branch
from
a48d8a2
to
5322760
Compare
SRIKKANTH
force-pushed
the
smyakam/NVMeSupportForNVMeDiskControlledVMs
branch
from
9611265
to
4bc9506
Compare
|
@SRIKKANTH please run basic functional and regression testing, I hit below error when run nvme functional tests. |
LiliDeng
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.