Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade paramiko #3233

Merged
merged 2 commits into from
Mar 30, 2024
Merged

Upgrade paramiko #3233

merged 2 commits into from
Mar 30, 2024

Conversation

squirrelsc
Copy link
Member

The new version paramiko is not supported by latest spurplus on versions, but the functionality works. So force install spurplus to work around the version conflicts.

@LiliDeng
Copy link
Collaborator

I saw below issue with this change

Traceback (most recent call last):
  File "C:\hostedtoolcache\windows\Python\3.10.11\x64\lib\runpy.py", line 196, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "C:\hostedtoolcache\windows\Python\3.10.11\x64\lib\runpy.py", line 86, in _run_code
    exec(code, run_globals)
  File "C:\hostedtoolcache\windows\Python\3.10.11\x64\Scripts\lisa.exe\__main__.py", line 4, in <module>
  File "D:\a\_work\1\s\lisa\lisa\__init__.py", line 6, in <module>
    from lisa.environment import Environment
  File "D:\a\_work\1\s\lisa\lisa\environment.py", line 19, in <module>
    from lisa.node import Node, Nodes
  File "D:\a\_work\1\s\lisa\lisa\node.py", line 22, in <module>
    from lisa.executable import Tools
  File "D:\a\_work\1\s\lisa\lisa\executable.py", line 24, in <module>
    from lisa.util.process import ExecutableResult, Process
  File "D:\a\_work\1\s\lisa\lisa\util\process.py", line 29, in <module>
    from lisa.util.shell import Shell, SshShell
  File "D:\a\_work\1\s\lisa\lisa\util\shell.py", line 18, in <module>
    import spurplus  # type: ignore
ModuleNotFoundError: No module named 'spurplus'

@squirrelsc
Copy link
Member Author

I saw below issue with this change

Traceback (most recent call last):
  File "C:\hostedtoolcache\windows\Python\3.10.11\x64\lib\runpy.py", line 196, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "C:\hostedtoolcache\windows\Python\3.10.11\x64\lib\runpy.py", line 86, in _run_code
    exec(code, run_globals)
  File "C:\hostedtoolcache\windows\Python\3.10.11\x64\Scripts\lisa.exe\__main__.py", line 4, in <module>
  File "D:\a\_work\1\s\lisa\lisa\__init__.py", line 6, in <module>
    from lisa.environment import Environment
  File "D:\a\_work\1\s\lisa\lisa\environment.py", line 19, in <module>
    from lisa.node import Node, Nodes
  File "D:\a\_work\1\s\lisa\lisa\node.py", line 22, in <module>
    from lisa.executable import Tools
  File "D:\a\_work\1\s\lisa\lisa\executable.py", line 24, in <module>
    from lisa.util.process import ExecutableResult, Process
  File "D:\a\_work\1\s\lisa\lisa\util\process.py", line 29, in <module>
    from lisa.util.shell import Shell, SshShell
  File "D:\a\_work\1\s\lisa\lisa\util\shell.py", line 18, in <module>
    import spurplus  # type: ignore
ModuleNotFoundError: No module named 'spurplus'

How do you install LISA?

@LiliDeng
Copy link
Collaborator

I saw below issue with this change

Traceback (most recent call last):
  File "C:\hostedtoolcache\windows\Python\3.10.11\x64\lib\runpy.py", line 196, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "C:\hostedtoolcache\windows\Python\3.10.11\x64\lib\runpy.py", line 86, in _run_code
    exec(code, run_globals)
  File "C:\hostedtoolcache\windows\Python\3.10.11\x64\Scripts\lisa.exe\__main__.py", line 4, in <module>
  File "D:\a\_work\1\s\lisa\lisa\__init__.py", line 6, in <module>
    from lisa.environment import Environment
  File "D:\a\_work\1\s\lisa\lisa\environment.py", line 19, in <module>
    from lisa.node import Node, Nodes
  File "D:\a\_work\1\s\lisa\lisa\node.py", line 22, in <module>
    from lisa.executable import Tools
  File "D:\a\_work\1\s\lisa\lisa\executable.py", line 24, in <module>
    from lisa.util.process import ExecutableResult, Process
  File "D:\a\_work\1\s\lisa\lisa\util\process.py", line 29, in <module>
    from lisa.util.shell import Shell, SshShell
  File "D:\a\_work\1\s\lisa\lisa\util\shell.py", line 18, in <module>
    import spurplus  # type: ignore
ModuleNotFoundError: No module named 'spurplus'

How do you install LISA?

I trigger a lisa job in pipeline, installed from Install LISA V3 Environment

@squirrelsc squirrelsc marked this pull request as draft March 27, 2024 20:16
@squirrelsc
Copy link
Member Author

How do you install LISA?

I trigger a lisa job in pipeline, installed from Install LISA V3 Environment

Thank you for validating, I just tested with nox. Let me look for a better solution.

@squirrelsc squirrelsc marked this pull request as ready for review March 30, 2024 00:32
@squirrelsc
Copy link
Member Author

@LiliDeng updated spurplus, it should be right now.

@LiliDeng LiliDeng merged commit 11234bb into microsoft:main Mar 30, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants