New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add environment core stats feature #3256
base: main
Are you sure you want to change the base?
Conversation
7c3a346
to
b0d053e
Compare
b0d053e
to
28e0686
Compare
3be96fd
to
d71ac61
Compare
env = EnvironmentVmsizeInfo(name=msg.name, status=msg.status) | ||
assert msg.runbook.nodes_requirement | ||
for node in msg.runbook.nodes_requirement: | ||
from .common import AzureLocation, AzureNodeSchema |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't need to import inline, move them to the top of the file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If in the top of the file, it has the following error.
File "/home/runner/work/lisa/lisa/.nox/example/bin/lisa", line 5, in
from lisa.main import cli
File "/home/runner/work/lisa/lisa/lisa/main.py", line 16, in
import lisa.mixin_modules # noqa: F401
File "/home/runner/work/lisa/lisa/lisa/mixin_modules.py", line 20, in
import lisa.sut_orchestrator.azure.notifiers # noqa: F401
File "/home/runner/work/lisa/lisa/lisa/sut_orchestrator/azure/notifiers.py", line 16, in
from .common import AzureLocation, AzureNodeSchema, load_location_info_from_file
File "/home/runner/work/lisa/lisa/lisa/sut_orchestrator/azure/common.py", line 17, in
import requests
ModuleNotFoundError: No module named 'requests'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check history of project.toml, the requests
package should be included in Azure too.
d71ac61
to
8799137
Compare
This feature can collect the core usage information, which can guide us to request the appropriate compute quota for the subscription.