modify cloud-init error pattern #3320
Conversation
| re.compile(r"^(.*\[WARNING\]*)$", re.MULTILINE), | ||
| re.compile(r"^(.*WARNING:*)$", re.MULTILINE), | ||
| re.compile(r"^(.*[ERROR]*)$", re.MULTILINE), | ||
| re.compile(r"^(.*[WARNING]*)$", re.MULTILINE), |
There was a problem hiding this comment.
The new pattern looks incorrect and wide. It matches like W, AWRING, IN or something else.
There was a problem hiding this comment.
Please add newly examples above, so you can test the new patterns without regressions.
There was a problem hiding this comment.
Thanks for pointing this out. I tested the new pattern ^(.[WARNING]:) on https://regex101.com/. Also, I removed the $ sign to make the match more tolerate. For now, the only pattern strings in cloud-init.log we want to match are "[ERROR]:" and "[WARNING]:"
| re.compile(r"^(.*ERROR:*)$", re.MULTILINE), | ||
| re.compile(r"^(.*\[WARNING\]*)$", re.MULTILINE), | ||
| re.compile(r"^(.*WARNING:*)$", re.MULTILINE), | ||
| re.compile(r"^(.*\[ERROR\]:.*)", re.MULTILINE), |
There was a problem hiding this comment.
Please add examples above, which error want or unwanted. The previous pattern captured patterns like ERROR: aaa. But they are removed. Please specify the reasons.
* modify cloud-init error pattern * modify cloud-init error pattern * modify cloud-init error pattern * modify cloud-init error pattern
Correct pattern matching list _ERROR_WARNING_pattern for cloud-init test in LISA. Previously, it does not properly catch message patter [ERROR] and [WARNING] in cloud-init.log